Remove the need to enable BMFF via API #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
force-pushed
the
kmilos/bmff_enabled_implicit
branch
from
b82428d
to
723fc43
Compare
kmilos
force-pushed
the
kmilos/bmff_enabled_implicit
branch
from
723fc43
to
9dd7e3c
Compare
kmilos
added
refactoring
kmilos
requested review from
neheb,
postscript-dev,
piponazo,
kevinbackhouse and
nehaljwani
kevinbackhouse
approved these changes
Jun 4, 2024
|
@kevinbackhouse Thanks. Any thoughts on backporting this to 0.28.x (and maybe a point release soon for other goodness)? |
Sorry I forgot to respond last week. This is fine with me. A point release sounds good too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BMFF support is either explicitly removed at build time, or is assumed to be on/available w/o a need for the second gating mechanism.
The
Exiv2::enableBMFF(bool)dummy is kept in the API for legacy apps for the time being. (Hopefully no one ever calledenableBMFF(false)!?)This is to remove the somewhat artificial constraint on thread safety.
I'd be bold and backport this to 0.28.x if there are no objections as a step towards leaving the whole BMFF IPR confusion behind... (and remove completely from API on main next?)