Fast reading for primitive types #71
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I often want to read the whole data from an array (using
.into_vec()).I have noticed that this is considerably slower for large arrays compared to numpy.
Numpy:

This crates takes 6 times as long just for reading:
output:

This boils down to the reader reading and parsing every primitive one by one.
In many cases, we can copy the data into memory and reinterpret it (this is also what Numpy does).
I added a fast read functionality for primitive types using the

bytemuckcrate.This makes it about 10 times faster:
What are your thoughts about this?
My solution adds minimal code and only speeds up the reads for the primitives where it is safe.
Sorry for the convoluted git history...please squash it on merge in GitHub.
Best
Simon