Add Kafka compression type for Kafka Metastore Listener #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patduin
reviewed
Jul 19, 2023
| @@ -28,7 +28,8 @@ public enum KafkaProducerProperty implements Property { | |||
| BATCH_SIZE("batch.size", 16384), | |||
| LINGER_MS("linger.ms", 1L), | |||
| BUFFER_MEMORY("buffer.memory", 33554432L), | |||
| SERDE_CLASS("serde.class", JsonMetaStoreEventSerDe.class.getName()); | |||
| SERDE_CLASS("serde.class", JsonMetaStoreEventSerDe.class.getName()), | |||
| COMPRESSION_TYPE("compression.type", "producer"); | |||
There was a problem hiding this comment.
this is the default right we don't really need this change?
There was a problem hiding this comment.
nevermind this is just to set the default again and allow for overrides in hive-site.xml
patduin
approved these changes
Jul 19, 2023
abhimanyugupta07
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding
compression.typeKafka property inkafka-metastore-listener.🔗 Related Issues