-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add personalized configuration parameters for each metastore. #315
Changes from 4 commits
d94d0a9
5b43c27
e9a93a1
394250d
14abc77
877a76a
085d7fc
cb7b7bf
8307404
f837b2e
bc64c92
8cb4b22
5bd959c
23258d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,8 @@ public CloseableThriftHiveMetastoreIface newInstance(AbstractMetaStore metaStore | |
if (waggleDanceConfiguration.getConfigurationProperties() != null) { | ||
properties.putAll(waggleDanceConfiguration.getConfigurationProperties()); | ||
} | ||
//override per metastore | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment isn't needed. |
||
properties.putAll(metaStore.getConfigurationProperties()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add a junit test please? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||
return newHiveInstance(metaStore, properties); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move these two methods below the
setDatabaseNameMapping
method to keep them in sync with the property definitions. Normally,toString
(if defined) is the last method in a class.