Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive 3.x backport readonly and ratelimit feature #321

Merged

Conversation

flaming-archer
Copy link
Contributor

📝 Description

Make sure that the 3.x branch and the main branch are not too far apart.

🔗 Related Issues

#319

@flaming-archer
Copy link
Contributor Author

@jmnunezizu @patduin pls take a look at it. The audit log, HMSHandler.getThreadLocalIpAddress was removed because of this method in hive 3.x is not public. It's not worth writing reflections for it alone.

@flaming-archer
Copy link
Contributor Author

This failed test case should have nothing to do with submission:Error: Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8:deploy (injected-nexus-deploy) on project waggle-dance-rpm: Failed to deploy artifacts: Could not transfer artifact com.hotels:waggle-dance-boot:jar:exec:4.0.0-20240626.031244-2 from/to sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots): authentication failed for https://oss.sonatype.org/content/repositories/snapshots/com/hotels/waggle-dance-boot/4.0.0-SNAPSHOT/waggle-dance-boot-4.0.0-20240626.031244-2-exec.jar, status: 401 Unauthorized -> [Help 1]

Copy link
Contributor

@patduin patduin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is looking good, test all ran green.

@flaming-archer
Copy link
Contributor Author

@jmnunezizu Could you pls review this and merge it.

@jmnunezizu
Copy link

@flaming-archer – thanks for porting the new features to the Hive 3.x branch!

@jmnunezizu jmnunezizu merged commit a58f325 into ExpediaGroup:hive-3.x Jul 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants