address review comments

Expensify · Oct 17, 2024 · 00a5466 · 00a5466
1 parent 7346c30
commit 00a5466
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -754,8 +754,8 @@ const CONST = {
     // Use Environment.getEnvironmentURL to get the complete URL with port number
     DEV_NEW_EXPENSIFY_URL: 'https://dev.new.expensify.com:',
     NAVATTIC: {
-        ADMIN_TOUR: 'http://expensify.navattic.com/kh204a7',
-        EMPLOYEE_TOUR: 'http://expensify.navattic.com/35609gb',
+        ADMIN_TOUR: 'https://expensify.navattic.com/kh204a7',
+        EMPLOYEE_TOUR: 'https://expensify.navattic.com/35609gb',
     },
 
     OLDDOT_URLS: {

diff --git a/src/components/EmptyStateComponent/index.tsx b/src/components/EmptyStateComponent/index.tsx
@@ -99,14 +99,13 @@ function EmptyStateComponent({
                         <Text style={[styles.textAlignCenter, styles.textHeadlineH1, styles.mb2, titleStyles]}>{title}</Text>
                         {typeof subtitle === 'string' ? <Text style={[styles.textAlignCenter, styles.textSupporting, styles.textNormal]}>{subtitle}</Text> : subtitle}
                         <View style={[styles.gap2, styles.mt5, !shouldUseNarrowLayout ? styles.flexRow : undefined]}>
-                            {buttons?.map(({buttonText, buttonAction, success}, index) => (
-                                // eslint-disable-next-line react/no-array-index-key
+                            {buttons?.map(({buttonText, buttonAction, success}, index) => (                              
                                 <View
+                                    // eslint-disable-next-line react/no-array-index-key
                                     key={index}
                                     style={styles.flex1}
                                 >
                                     <Button
-                                        // eslint-disable-next-line react/no-array-index-key
                                         success={success}
                                         onPress={buttonAction}
                                         text={buttonText}

diff --git a/src/languages/es.ts b/src/languages/es.ts
@@ -4292,8 +4292,8 @@ const translations = {
                 subtitle: 'Por favor intenta crear algo usando el botón verde.',
             },
             emptyExpenseResults: {
-                title: "You haven't created any expenses yet",
-                subtitle: 'Use the green button below to create an expense or take a tour of Expensify to learn more.',
+                title: 'Aún no has creado ningún gasto',
+                subtitle: 'Usa el botón verde de abajo para crear un gasto o realiza un recorrido por Expensify para aprender más.',
             },
             emptyTripResults: {
                 title: 'No tienes viajes',
@@ -5598,7 +5598,7 @@ const translations = {
         },
     },
     emptySearchView: {
-        takeATour: 'Take a tour',
+        takeATour: 'Realiza un recorrido',
     },
 };
 

diff --git a/src/pages/Search/EmptySearchView.tsx b/src/pages/Search/EmptySearchView.tsx
@@ -113,7 +113,6 @@ function EmptySearchView({type}: EmptySearchViewProps) {
                         },
                     ],
                 };
-            case CONST.SEARCH.DATA_TYPES.CHAT:
             case CONST.SEARCH.DATA_TYPES.EXPENSE:
                 return {
                     headerMedia: LottieAnimations.GenericEmptyState,
@@ -130,6 +129,7 @@ function EmptySearchView({type}: EmptySearchViewProps) {
                     ],
                     headerContentStyles: styles.emptyStateFolderWebStyles,
                 };
+            case CONST.SEARCH.DATA_TYPES.CHAT:
             case CONST.SEARCH.DATA_TYPES.INVOICE:
             default:
                 return {