-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pressing enter doesn't select the emoji category #50971
Open
bernhardoj
wants to merge
1
commit into
Expensify:main
Choose a base branch
from
bernhardoj:fix/50561-enter-doesnt-press-emoji-category-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you remove the whole condition, Shouldn't we keep the return early here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because it won't affect the code below it.
App/src/components/EmojiPicker/EmojiPickerMenu/index.tsx
Lines 150 to 161 in c3d33fc
For
App/src/components/EmojiPicker/EmojiPickerMenu/index.tsx
Lines 157 to 160 in c3d33fc
it's only executed if
shouldAutoFocusOnKeyPress
is true which is false for ENTER.App/src/libs/ReportUtils.ts
Lines 7595 to 7598 in c3d33fc
For
App/src/components/EmojiPicker/EmojiPickerMenu/index.tsx
Lines 150 to 155 in c3d33fc
the keyboard movement state is used to show the focused state of emoji item.
App/src/components/EmojiPicker/EmojiPickerMenu/index.tsx
Line 271 in c3d33fc
The emoji will be focused when we use arrow key, tab, or hold down mouse on it. The time we press Enter, the emoji will be selected. From my understanding, the
isUsingKeyboardMovement
state is used to not show the blue outline on the emoji when focused using mouse.But it will still show anyway with the mouse because when focused, we update the focused index.
App/src/components/EmojiPicker/EmojiPickerMenu/index.tsx
Line 293 in c3d33fc
which always update
isUsingKeyboardMovement
to true.App/src/components/EmojiPicker/EmojiPickerMenu/index.tsx
Lines 75 to 87 in c3d33fc
We can remove Enter from the
if
if you want.App/src/components/EmojiPicker/EmojiPickerMenu/index.tsx
Line 153 in c3d33fc