fix: the checkbox 'Select all' is announced non-descriptively by daledah · Pull Request #80464 · Expensify/App

daledah · 2026-01-26T04:42:31Z

Explanation of Change

Fixed Issues

$ #76961
PROPOSAL: #76961 (comment)

Tests

Prerequisites:

Use Chrome + JAWS on web
Use VoiceOver on iOS
Use TalkBack on Android

Go to the Workspaces section.
Choose More options icon (three vertical dots) > Duplicate Workspace
Click to the Next button and press Enter to activate it.
Select to the 'Select all' checkbox and observe the screen reader announcement.
Verify that: The checkbox should be announced with a clear, descriptive label that conveys its purpose, e.g.:

'select all features'
Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-26T04:42:37Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-01-27T17:48:38Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2026-01-29T12:30:49Z

@daledah, there are more "Select All" checkboxes throughout the app (6 files total), search for 'workspace.people.selectAll' too

daledah · 2026-02-02T18:14:38Z

@eVoloshchak i added

src/languages/en.ts

daledah · 2026-02-09T04:14:21Z

@eVoloshchak i updated

eVoloshchak · 2026-02-10T09:59:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

eVoloshchak · 2026-02-10T13:08:26Z

Works well! @daledah, could you please include the test steps so the QA can test this? (we have to use VoiceOver on iOS and TalkBack on Android)

daledah · 2026-02-10T16:31:12Z

@eVoloshchak i added the steps

eVoloshchak

LGTM!

dangrous

LGTM! - Just to confirm, did we get the spanish translations approved?

dangrous · 2026-02-12T15:40:29Z

src/languages/es.ts

        viewAttachment: 'Ver archivo adjunto',
+        selectAllFeatures: 'Seleccionar todas las características',
+        selectAllItems: 'Seleccionar todos los elementos',
+        selectAllTransactions: 'Seleccionar todos los gastos',


Pretty sure at least this one should be transacciones based on the other strings in es.ts - let's run these by Slack please, then we can move forward!

Asking here https://expensify.slack.com/archives/C01GTK53T8Q/p1770915818711429

Thanks! looks like transacciones but otherwise we should be good. Ready to approve/merge once that's set!

@dangrous i updated

dangrous · 2026-02-18T18:58:15Z

conflicts, then I think we're just waiting on product review if we need it

daledah · 2026-02-19T03:25:46Z

I resolved conflict

dangrous · 2026-02-19T16:04:53Z

annnnnd now typecheck / lint errors. Sorry!

heyjennahay

Product review not required

dangrous · 2026-02-20T16:04:49Z

k @daledah can you look at those errors? Then we can get this done!

daledah · 2026-02-21T05:08:43Z

@dangrous all looks good now

fix: the checkbox 'Select all' is announced non-descriptively

6eb0b24

melvin-bot bot assigned daledah Jan 26, 2026

Merge branch 'main' into fix/76961

c01edda

daledah marked this pull request as ready for review January 27, 2026 17:48

daledah requested review from a team as code owners January 27, 2026 17:48

melvin-bot bot requested review from eVoloshchak and heyjennahay and removed request for a team January 27, 2026 17:48

daledah added 2 commits February 3, 2026 01:07

resolve conflict

68cd034

add missing label

801756c

eVoloshchak suggested changes Feb 5, 2026

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

daledah added 2 commits February 7, 2026 20:09

resolved conflict and move translations

d3e121a

fix lint

606b0cd

eVoloshchak approved these changes Feb 10, 2026

View reviewed changes

melvin-bot bot requested a review from dangrous February 10, 2026 20:35

dangrous approved these changes Feb 11, 2026

View reviewed changes

dangrous requested changes Feb 12, 2026

View reviewed changes

daledah added 2 commits February 16, 2026 12:41

Merge branch 'main' into fix/76961

f9840d5

update transactions

140b530

dangrous previously approved these changes Feb 17, 2026

View reviewed changes

resolve conflict

f399938

daledah dismissed dangrous’s stale review via f399938 February 19, 2026 03:25

heyjennahay reviewed Feb 20, 2026

View reviewed changes

daledah added 3 commits February 21, 2026 11:51

Merge branch 'main' into fix/76961

81e3eb6

fix ts error

bc067cb

fix lint

a783652

Comments

Conversation

daledah commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 26, 2026

Uh oh!

melvin-bot bot commented Jan 27, 2026

Uh oh!

eVoloshchak commented Jan 29, 2026

Uh oh!

daledah commented Feb 2, 2026

Uh oh!

Uh oh!

daledah commented Feb 9, 2026

Uh oh!

eVoloshchak commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Feb 10, 2026

Uh oh!

daledah commented Feb 10, 2026

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

dangrous Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

dangrous commented Feb 18, 2026

Uh oh!

daledah commented Feb 19, 2026

Uh oh!

dangrous commented Feb 19, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous commented Feb 20, 2026

Uh oh!

daledah commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Jan 26, 2026 •

edited

Loading

eVoloshchak commented Feb 10, 2026 •

edited

Loading