Skip to content

Comments

Suggested response buttons style update#83048

Open
jmusial wants to merge 4 commits intoExpensify:mainfrom
software-mansion-labs:feat/word-clip-follow-up-buttons-v2
Open

Suggested response buttons style update#83048
jmusial wants to merge 4 commits intoExpensify:mainfrom
software-mansion-labs:feat/word-clip-follow-up-buttons-v2

Conversation

@jmusial
Copy link
Contributor

@jmusial jmusial commented Feb 20, 2026

Explanation of Change

This PR is a second version of reverted #82113. DB link

It changes the styles for phrasal response concierge buttons. (ADDCOMMENT w/ followups, CONCIERGEDESCRIPTIONOPTIONS and CONCIERGECATEGORYOPTIONS).

Fixed Issues

$ #81748
PROPOSAL:
N/A

Tests

  1. Create a new account (in either @swmansion.com or @dmb.fun domains. Can be any fake email, you do not need to enter the magic code.)
  2. In the onboarding for a new user that "Manages my team's expenses" and "1-10".
  3. Get a welcome message w/ follow ups in the #admins chat.
  4. Verify that the styles are correct (as on screenshots).
  5. Create an expense and have Concierge propose the categories and/or description.
  6. Verify that the styles are correct (as on screenshots).
  7. Verify that all other Concierge (ex. whispers) have old buttons styles.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari Desktop: image

Mobile:
image

Super narrow screen (word break):
image

Whispers:
image

@jmusial jmusial changed the title update Actionable buttons styles only for phrasal options Suggested response buttons style update Feb 20, 2026
@jmusial jmusial marked this pull request as ready for review February 20, 2026 14:03
@jmusial jmusial requested review from a team as code owners February 20, 2026 14:03
@jmusial
Copy link
Contributor Author

jmusial commented Feb 20, 2026

@Expensify/design please take a look and confirm that this are all the buttons that are considered phrasal response buttons that we need to change (sshots in the description)

@melvin-bot melvin-bot bot requested review from bernhardoj and heyjennahay and removed request for a team February 20, 2026 14:03
@melvin-bot
Copy link

melvin-bot bot commented Feb 20, 2026

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 20, 2026 14:03
@jmusial
Copy link
Contributor Author

jmusial commented Feb 20, 2026

@bernhardoj I think this one counts as a regression from #82113 and @abzokhattab should do the review as the reviewer of the OG PR?

@shawnborton
Copy link
Contributor

The screenshots don't look quite right. I believe the design team landed on making these phrasal response buttons (PRBs!) look similar to product buttons so we don't have the confusion of multiple button shapes.

To make this work in practice, this means that each phrasal response button needs to essentially have 20px of border radius with a 40px height. So that as the button grows, we get this effect:

CleanShot.2026-02-20.at.15.26.56.mp4

Button details:
CleanShot 2026-02-20 at 15 27 50@2x

  • min-height: 40px
  • padding-horizontal: 16px
  • padding-vertical: 8px
  • border-radius: 20px

Then the max-width would be the width of the container that it is in. Let me know how that sounds!

@shawnborton
Copy link
Contributor

cc @Expensify/design for the gut check on that

@jmusial
Copy link
Contributor Author

jmusial commented Feb 20, 2026

The screenshots don't look quite right. I believe the design team landed on making these phrasal response buttons (PRBs!) look similar to product buttons so we don't have the confusion of multiple button shapes.

To make this work in practice, this means that each phrasal response button needs to essentially have 20px of border radius with a 40px height. So that as the button grows, we get this effect:

CleanShot.2026-02-20.at.15.26.56.mp4
Button details: CleanShot 2026-02-20 at 15 27 50@2x

  • min-height: 40px
  • padding-horizontal: 16px
  • padding-vertical: 8px
  • border-radius: 20px

Then the max-width would be the width of the container that it is in. Let me know how that sounds!

Yeah, sorry - totally missed the convo and decision on slack 😢 .
Changes look ok for me, will implement and let you know

cc. @Beamanator we need to update emails as well

@dannymcclain
Copy link
Contributor

@shawnborton that all sounds right to me!

phrasal response buttons (PRBs!)

🤣 Hate it and love it and am definitely going to use PRB in Slack/GH from now on 🤣

@jmusial jmusial requested a review from a team as a code owner February 20, 2026 17:05
@jmusial
Copy link
Contributor Author

jmusial commented Feb 20, 2026

Updated styles
image

image

@dannymcclain
Copy link
Contributor

Oh I am digging that. Let's see what the rest of the @Expensify/design team thinks!

(Also, thank you @jmusial - I know we've messed with these buttons waaaaaaaaaaay more than any of us expected 😅)

@marcochavezf marcochavezf self-requested a review February 20, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants