Skip to content

Fix: Remove generic error from failureData and move public domain check in Travel Invoicing #83095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MelvinBot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix: Remove generic error from failureData and move public domain check in Travel Invoicing #83095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c3eb17
Fix: Remove generic error from failureData and move public domain che…
MelvinBot Feb 20, 2026
9a567cf
Remove generic error expectation from toggleTravelInvoicing test
MelvinBot Feb 20, 2026
e2dabea
Fix: Update TravelInvoicingTest to match removal of errors from failu…
MelvinBot Feb 20, 2026
aafbb30
Merge branch 'claude-fixTravelInvoicingErrorAndPublicDomainCheck' of …
MelvinBot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libs/actions/TravelInvoicing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ function toggleTravelInvoicing(policyID: string, workspaceAccountID: number, ena
isEnabled: !enabled,
},
pendingAction: null,
errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
},
},
];
Expand Down
12 changes: 6 additions & 6 deletions src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
* When turning OFF: show confirmation modal, then call toggleTravelInvoicing(false).
*/
const handleToggle = (isEnabled: boolean) => {
// Check if user is on a public domain - Travel Invoicing requires a private domain
if (account?.isFromPublicDomain) {
Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.getRoute(Navigation.getActiveRoute()));
return;
}

if (!isEnabled) {
// Trying to disable - check for outstanding balance first
if (hasOutstandingTravelBalance(cardSettings)) {
Expand All @@ -127,12 +133,6 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
return;
}

// Check if user is on a public domain - Travel Invoicing requires a private domain
if (account?.isFromPublicDomain) {
Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.getRoute(Navigation.getActiveRoute()));
return;
}

// Turning ON - check if bank account setup is needed first
if (!eligibleBankAccounts.length || isSetupUnfinished) {
// No bank accounts - start add bank account flow
Expand Down
1 change: 0 additions & 1 deletion tests/unit/TravelInvoicingTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ describe('TravelInvoicing', () => {
isEnabled: !enabled,
}),
pendingAction: null,
errors: expect.anything() as unknown,
}),
}),
]),
Expand Down
Loading