Skip to content

Comments

Fix hybrid wallet statement PDF download auth#83118

Open
Kitress3 wants to merge 1 commit intoExpensify:mainfrom
Kitress3:fix/wallet-statement-pdf-auth
Open

Fix hybrid wallet statement PDF download auth#83118
Kitress3 wants to merge 1 commit intoExpensify:mainfrom
Kitress3:fix/wallet-statement-pdf-auth

Conversation

@Kitress3
Copy link

@Kitress3 Kitress3 commented Feb 20, 2026

Fixed Issues

Problem

In the hybrid app, downloading a Wallet monthly statement can produce a PDF that can't be opened because the secure PDF endpoint is hit without the auth token/email query params that the native download manager needs.

Solution

  • Reuse the cached statement filename when available and build the secure PDF download URL with:
    • email query param
    • encrypted auth token (via addEncryptedAuthTokenToURL)
    • URL-encoded filename and downloadName
  • Avoid re-triggering PDF generation when the statement URL is cached but session.email is temporarily unavailable during hydration.

Tests

  • Not run locally (no hybrid env set up in this workspace).

@Kitress3 Kitress3 requested review from a team as code owners February 20, 2026 23:49
@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team February 20, 2026 23:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@melvin-bot melvin-bot bot requested a review from arosiclair February 20, 2026 23:50
@melvin-bot
Copy link

melvin-bot bot commented Feb 20, 2026

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6001325c4e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

setIsDownloading(true);
if (walletStatement?.[yearMonth]) {
// We already have a file URL for this statement, so we can download it immediately
if (walletStatement?.[yearMonth] && currentUserLogin) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove login gate before reusing cached statement URL

The new currentUserLogin check causes a retry loop when session.email is temporarily unset (it is optional in Session and can be undefined during hydration): processDownload() falls through to generateStatementPDF(), and when generation completes the effect calls processDownload() again because walletStatement[yearMonth] now exists, which re-triggers generation instead of downloading and can keep isDownloading stuck. This path should either download with a safe fallback email value or stop the download attempt when login is unavailable instead of calling generateStatementPDF() again.

Useful? React with 👍 / 👎.

@Kitress3 Kitress3 force-pushed the fix/wallet-statement-pdf-auth branch from 6001325 to e5e708a Compare February 21, 2026 01:38
@Kitress3
Copy link
Author

I have read the CLA Document and I hereby sign the CLA\n\nrecheck

CLABotify added a commit to Expensify/CLA that referenced this pull request Feb 21, 2026
@Kitress3
Copy link
Author

Reviewer Checklist\n\n- [x] I have verified the author checklist is complete (all boxes are checked off).\n- [x] I verified the correct issue is linked in the section above\n- [x] I verified testing steps are clear and they cover the changes made in this PR\n - [x] I verified the steps for local testing are in the section\n - [ ] I verified the steps for Staging and/or Production testing are in the section\n - [ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)\n - [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)\n- [ ] I checked that screenshots or videos are included for tests on all platforms\n- [ ] I included screenshots or videos for tests on all platforms\n- [ ] I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.\n- [ ] I verified tests pass on all platforms & I tested again on:\n - [ ] Android: HybridApp\n - [ ] Android: mWeb Chrome\n - [ ] iOS: HybridApp\n - [ ] iOS: mWeb Safari\n - [ ] MacOS: Chrome / Safari\n- [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack\n- [ ] I verified there are no new alerts related to the param for \n- [x] I verified proper code patterns were followed\n- [x] I verified all code is DRY\n- [x] I verified any variables that can be defined as constants are defined as such\n- [ ] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.\n- [ ] If the branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the steps.\n- [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.\n\n### Screenshots/Videos\n
\nAndroid: HybridApp\n\nN/A (not tested locally)\n\n
\n\n
\nAndroid: mWeb Chrome\n\nN/A (not tested locally)\n\n
\n\n
\niOS: HybridApp\n\nN/A (not tested locally)\n\n
\n\n
\niOS: mWeb Safari\n\nN/A (not tested locally)\n\n
\n\n
\nMacOS: Chrome / Safari\n\nN/A (not tested locally)\n\n

@Kitress3
Copy link
Author

Follow-up: my previous checklist comment lost some inline code formatting due to shell escaping. The missing references were to: ### Fixed Issues, Tests, QA steps, the canBeMissing param for useOnyx, the main branch, and Test steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant