Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockquote paddings and remove backedTextInputView #289

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

maksg
Copy link
Contributor

@maksg maksg commented Apr 11, 2024

Details

Completely removes backedTextInputView and changes where it gets padding from for blockquotes. It was broken by #199.

Manual Tests

This is a visual change. You can see that the grey block is misaligned without this.

Copy link

github-actions bot commented Apr 11, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@maksg
Copy link
Contributor Author

maksg commented Apr 11, 2024

I have read the CLA Document and I hereby sign the CLA

@maksg
Copy link
Contributor Author

maksg commented Apr 11, 2024

recheck

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! ✅

Screenshot 2024-04-11 at 16 54 09

@maksg maksg force-pushed the @maksg/remove-backed-text-view branch from 2cf81e1 to c67a725 Compare April 11, 2024 15:22
@tomekzaw tomekzaw merged commit 877fbfa into Expensify:main Apr 11, 2024
2 checks passed
@maksg maksg deleted the @maksg/remove-backed-text-view branch April 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants