Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Markdown style in README #305

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Update default Markdown style in README #305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7da219
Update default Markdown style in README
tomekzaw Apr 12, 2024
874641c
Add `FONT_FAMILY_MONOSPACE` definition
tomekzaw Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ It is also possible to customize the styling of the formatted contents of `Markd
```tsx
import type {MarkdownStyle} from '@expensify/react-native-live-markdown';

const FONT_FAMILY_MONOSPACE = Platform.select({
ios: 'Courier',
default: 'monospace',
});

const markdownStyle: MarkdownStyle = {
syntax: {
color: 'gray',
Expand All @@ -67,19 +72,24 @@ const markdownStyle: MarkdownStyle = {
h1: {
fontSize: 25,
},
emoji: {
fontSize: 20,
},
blockquote: {
borderColor: 'gray',
borderWidth: 6,
marginLeft: 6,
paddingLeft: 6,
},
code: {
fontFamily: 'monospace',
fontFamily: FONT_FAMILY_MONOSPACE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add FONT_FAMILY_MONOSPACE variable definition

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can safely omit the definition in README.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 874641c

fontSize: 20,
color: 'black',
backgroundColor: 'lightgray',
},
pre: {
fontFamily: 'monospace',
fontFamily: FONT_FAMILY_MONOSPACE,
fontSize: 20,
color: 'black',
backgroundColor: 'lightgray',
},
Expand Down
Loading