Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Android - Live markdown style not applied consistently #590

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ikevin127
Copy link
Contributor

Details

Coming from this E/App issue:

only on Android: Native, the input live markdown styling was not being applied on subsequent component mount. More details can be found in the issue on why and how we went about fixing the issue.

cc @tomekzaw as you already have context on the discussions and approved the solution

Related Issues

Manual Tests

Note: Not reproducible with the example app because it doesn't have a navigation stack and the component structure which led to the issue in E/App.

E/App Tests

  1. Go to FAB > Submit expense > Manual.
  2. Enter amount > Next.
  3. Select a recipient.
  4. Tap Description.
  5. Enter text with markdown and save.
  6. Tap Description again and verify that the markdown styling is applied when the input is mounted.
Before After
android-before.mp4
android.mp4

Linked PRs

Copy link

github-actions bot commented Dec 18, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ikevin127
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@tomekzaw tomekzaw merged commit 8b1789a into Expensify:main Dec 18, 2024
5 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented Dec 18, 2024

🚀 Published to npm in 0.1.210 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants