Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return empty array instead of throwing error if text !== markdown #593

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

daledah
Copy link
Contributor

@daledah daledah commented Jan 6, 2025

Details

This PR fixes a bug where pressing enter/new line key doesn't cause the url text to be moved to a new line.

Related Issues

Expensify/App#54522

Manual Tests

Linked PRs

Copy link

github-actions bot commented Jan 6, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@daledah
Copy link
Contributor Author

daledah commented Jan 6, 2025

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Jan 6, 2025
tomekzaw
tomekzaw previously approved these changes Jan 6, 2025
@tomekzaw
Copy link
Collaborator

tomekzaw commented Jan 6, 2025

@daledah Thanks for the PR!

@daledah daledah marked this pull request as ready for review January 6, 2025 18:42
@tomekzaw tomekzaw merged commit 7b34f62 into Expensify:main Jan 6, 2025
5 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented Jan 6, 2025

🚀 Published to npm in 0.1.212 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants