-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove splitting ranges on emojis on the web #598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2025
BartoszGrajdek
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
One problem I have is that it's not possible to use CMD + ➡️
when the cursor is in front of emoji. (not sure if that's a blocker cc @tomekzaw)
SR
Screen.Recording.2025-01-16.at.16.17.18.mov
shubham1206agra
approved these changes
Jan 16, 2025
tomekzaw
reviewed
Jan 16, 2025
tomekzaw
reviewed
Jan 16, 2025
tomekzaw
reviewed
Jan 16, 2025
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Skalakid
force-pushed
the
@Skalakid/fix-splitting-emojis-on-web
branch
from
January 20, 2025 07:31
283f5c6
to
d96bd19
Compare
Skalakid
force-pushed
the
@Skalakid/fix-splitting-emojis-on-web
branch
from
January 20, 2025 07:33
d96bd19
to
b57de63
Compare
tomekzaw
approved these changes
Jan 20, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes the problem with triplicating syntaxes inside the Live Markdown Input, by removing range-splitting logic from the web platform and replacing it with the fix based on CSS styles. In the future, we will focus on fixing the web parser to support splitting emojis among all other styles (especially inline code block) and properly handle tag hierarchy edge cases when building HTML structure.
Related Issues
Expensify/App#55115
Manual Tests
_🥰 test 😇 test 🥹_
# *~_🥰 test 😇 test 🥹_~*
Linked PRs
#597