Improve memoization of processedMarkdownStyle on web#684
Merged
Skalakid merged 4 commits intoExpensify:mainfrom Jun 3, 2025
Merged
Improve memoization of processedMarkdownStyle on web#684Skalakid merged 4 commits intoExpensify:mainfrom
processedMarkdownStyle on web#684Skalakid merged 4 commits intoExpensify:mainfrom
Conversation
jmusial
changed the title
jmusial
changed the title
Skalakid
previously approved these changes
May 29, 2025
Contributor
Skalakid
left a comment
Skalakid
left a comment
There was a problem hiding this comment.
LGTM, left on code formatting comment
tomekzaw
changed the title
processedMarkdownStyle on web
Skalakid
approved these changes
Jun 3, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Use hashed memoized
markdownStylesinternally to avoid redundant rerenders.It adds less code than #547
Related Issues
Closes #544.
Manual Tests
useMemofrommarkdownStyle(done in the PR already)Videos
Before
Screen.Recording.2025-05-28.at.12.37.07.mov
After
Screen.Recording.2025-05-28.at.12.37.44.mov
Linked PRs