Skip to content

Gracefully handle HostAppURLScheme #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Gracefully handle HostAppURLScheme #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions IOS_INSTRUCTIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Add the following to your app's `Info.plist` (if you already had other URL Schem
<key>CFBundleURLSchemes</key>
<array>
<string>A_URL_SCHEME_UNIQUE_TO_YOUR_APP</string>
<!-- This url scheme doesn't contain :// at the end - E.G. "mycustomscheme"-->
<!-- This URL scheme doesn't contain :// at the end - e.g. "mycustomscheme" -->
</array>
</dict>
</array>
Expand All @@ -110,7 +110,7 @@ Add the following to your Share Extension's `Info.plist`:
<string>YOUR_APP_TARGET_BUNDLE_ID</string>
<key>HostAppURLScheme</key>
<string>YOUR_APP_URL_SCHEME_DEFINED_ABOVE</string>
<!-- This url scheme CONTAINS :// at the end - E.G. "mycustomscheme://"-->
<!-- A URL with a scheme as defined in CFBundleURLSchemes above. Can be just the scheme or a more specific URL e.g. "mycustomscheme://share" -->
<key>NSExtension</key>
<dict>
<key>NSExtensionAttributes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/ShareViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ class ShareViewController: SLComposeServiceViewController {
return
}

let url = URL(string: urlScheme)
let url = URL(string: urlScheme.contains("://") ? urlScheme : "\(urlScheme)://")
let selectorOpenURL = sel_registerName("openURL:")
var responder: UIResponder? = self

Expand Down