minor changes after code review

Expensify · May 23, 2023 · 0f17587 · 0f17587
1 parent 6513a91
commit 0f17587
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/Libraries/Components/TextInput/TextInput.d.ts b/Libraries/Components/TextInput/TextInput.d.ts
@@ -576,12 +576,14 @@ export interface TextInputProps
   /**
    * Allows to adjust caret height.
    * The default value is 0, which means the height of the caret will be calculated automatically
+   * @platform ios
    */
   caretHeight?: number | undefined;
 
   /**
-   * Allows to adjust caret postiion relative to the Y axis
+   * Allows to adjust caret position relative to the Y axis
    * The default value is 0.
+   * @platform ios
    */
   caretYOffset?: number | undefined;
 

diff --git a/Libraries/Components/TextInput/TextInput.flow.js b/Libraries/Components/TextInput/TextInput.flow.js
@@ -560,12 +560,14 @@ export type Props = $ReadOnly<{|
   /**
    * Allows to adjust caret height.
    * The default value is 0, which means the height of the caret will be calculated automatically
+   * @platform ios
    */
-
   caretYOffset?: ?number,
+
   /**
-   * Allows to adjust caret postiion relative to the Y axis
+   * Allows to adjust caret position relative to the Y axis
    * The default value is 0.
+   * @platform ios
    */
   caretYHeight?: ?number,
 

diff --git a/Libraries/Components/TextInput/TextInput.js b/Libraries/Components/TextInput/TextInput.js
@@ -371,12 +371,14 @@ type IOSProps = $ReadOnly<{|
   /**
    * Allows to adjust caret height.
    * The default value is 0, which means the height of the caret will be calculated automatically
+   * @platform ios
    */
   caretYOffset?: ?number,
 
   /**
-   * Allows to adjust caret postiion relative to the Y axis
+   * Allows to adjust caret position relative to the Y axis
    * The default value is 0.
+   * @platform ios
    */
   caretHeight?: ?number,
 |}>;
@@ -1470,8 +1472,6 @@ function InternalTextInput(props: Props): React.Node {
         selection={selection}
         style={style}
         text={text}
-        caretYOffset={props.caretYOffset}
-        caretHeight={props.caretHeight}
       />
     );
   } else if (Platform.OS === 'android') {

diff --git a/Libraries/Text/TextInput/Multiline/RCTUITextView.m b/Libraries/Text/TextInput/Multiline/RCTUITextView.m
@@ -339,10 +339,11 @@ - (CGRect)caretRectForPosition:(UITextPosition *)position
     originalRect.origin.y += _caretYOffset;
   }
 
-    if(_caretHeight != 0) {
+  if(_caretHeight != 0) {
     originalRect.size.height = _caretHeight;
   }
-    return originalRect;
+
+  return originalRect;
 }
 
 - (NSArray *)selectionRectsForRange:(UITextRange *)range {

diff --git a/ReactCommon/react/renderer/components/textinput/iostextinput/primitives.h b/ReactCommon/react/renderer/components/textinput/iostextinput/primitives.h
@@ -160,7 +160,6 @@ class TextInputTraits final {
    * iOS-only (inherently iOS-specific)
    * Default value: 0 with a default font.
    */
-
   int caretHeight{0};
 
   /*