Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD facebook/react-native#37465] Fix TextInput vertical alignment issue when using lineHeight prop on iOS (Paper - old arch) #57

Closed
wants to merge 9 commits into from
Closed

[HOLD facebook/react-native#37465] Fix TextInput vertical alignment issue when using lineHeight prop on iOS (Paper - old arch) #57

wants to merge 9 commits into from

Commits on May 22, 2023

  1. Fix TextInput vertical alignment issue when using lineHeight prop on … 

    …iOS (Paper - old arch)
    @fabOnReact
    fabOnReact committed May 22, 2023
    Configuration menu
    Copy the full SHA
    17be5ef View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. fix indentation

    @fabOnReact
    fabOnReact committed May 23, 2023
    Configuration menu
    Copy the full SHA
    dfc2b20 View commit details
    Browse the repository at this point in the history

  2. revert fix from PR facebook#54

    @fabOnReact
    fabOnReact committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7dbfde4 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. update code comments 

    https://github.com/Expensify/react-native/pull/57/files#r1204428114
    @fabOnReact
    fabOnReact committed May 25, 2023
    Configuration menu
    Copy the full SHA
    12b51dd View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. changes requested in code review 

    Expensify#57 (comment)
    @fabOnReact
    fabOnReact committed May 30, 2023
    Configuration menu
    Copy the full SHA
    613bf0a View commit details
    Browse the repository at this point in the history

  2. minor improvement

    @fabOnReact
    fabOnReact committed May 30, 2023
    Configuration menu
    Copy the full SHA
    a5ac3c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. adding a line break before comment

    @fabOnReact
    fabOnReact committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    3d12d11 View commit details
    Browse the repository at this point in the history

  2. rerun ci

    @fabOnReact
    fabOnReact committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    0dae434 View commit details
    Browse the repository at this point in the history

  3. remove comment rerun ci

    @fabOnReact
    fabOnReact committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    a1433f3 View commit details
    Browse the repository at this point in the history