Merge pull request #634 from gbisaga/issues/626

Fix type error and pass actual entered baud rate
ExpressLRS · Jul 18, 2024 · 41df250 · 41df250
2 parents 874e0fe + dad638f
commit 41df250
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/graphql.schema.json b/graphql.schema.json
@@ -2689,11 +2689,11 @@
               "name": null,
               "ofType": {
                 "kind": "SCALAR",
-                "name": "String",
+                "name": "Float",
                 "ofType": null
               }
             },
-            "defaultValue": "\"420000\"",
+            "defaultValue": "420000",
             "isDeprecated": false,
             "deprecationReason": null
           },

diff --git a/src/api/src/graphql/inputs/SerialConnectionConfigInput.ts b/src/api/src/graphql/inputs/SerialConnectionConfigInput.ts
@@ -5,7 +5,7 @@ export default class SerialConnectionConfigInput {
   @Field(() => String)
   port: string;
 
-  @Field(() => String)
+  @Field(() => Number)
   baudRate: number;
 
   constructor() {

diff --git a/src/ui/components/SerialConnectionForm/index.tsx b/src/ui/components/SerialConnectionForm/index.tsx
@@ -123,7 +123,7 @@ const SerialConnectionForm: FunctionComponent<SerialConnectionFormProps> = (
   }, [data, previousData]);
   const onSubmit = () => {
     if (currentValue !== null) {
-      onConnect(currentValue?.value, baudRate);
+      onConnect(currentValue?.value, currentBaud);
     }
   };
   return (

diff --git a/src/ui/gql/generated/types.ts b/src/ui/gql/generated/types.ts
@@ -336,7 +336,7 @@ export type Release = {
 };
 
 export type SerialConnectionConfigInput = {
-  readonly baudRate?: Scalars['String']['input'];
+  readonly baudRate?: Scalars['Float']['input'];
   readonly port?: Scalars['String']['input'];
 };
 

diff --git a/src/ui/views/SerialMonitorView/index.tsx b/src/ui/views/SerialMonitorView/index.tsx
@@ -86,7 +86,7 @@ const SerialMonitorView: FunctionComponent = () => {
       variables: {
         input: {
           port: newSerialDevice,
-          baudRate: newBaudRate.toString(),
+          baudRate: newBaudRate,
         },
       },
     })