Conversation
Small Improvements
Collaborator
Good call!!
Ah yes, good catch!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small Improvements
In the same spirit as your last PR: #376
I have made 2 small adjustments for dev.
Visually the Format type for the core shell script is redundant with the option of "Email Format Type" displaying the format. It simply looks better I think:
Also walked back a change from my previous PR here: #367 , and instead decided to specifically select to remove the Gnuton branch, else we get this with offline flashing of Alphas:
So there is a reason we are being picky after all and not removing all suffixes, and it's related to the alphas and betas which I didn't consider the first time.