Skip to content

Fixes to handle AMTM Email Config File NOT found#397

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:WebFunfrom
Martinski4GitHub:WebFun
Jan 29, 2025
Merged

Fixes to handle AMTM Email Config File NOT found#397
ExtremeFiretop merged 1 commit intoExtremeFiretop:WebFunfrom
Martinski4GitHub:WebFun

Conversation

@Martinski4GitHub
Copy link
Collaborator

Made fixes & improvements to handle the scenario where the AMTM email config file is NOT found so that all email notification parameters must be shown as disabled on the WebGUI page.

Made code improvements to handle the scenario where the AMTM email config file is not found so that all email notification parameters must be shown as disabled on the WebGUI page.
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,

This PR now handles the issue you found WRT the AMTM config file not found & disabling the associated email notification parameters on the WebGUI page. Here are some screenshots showing 3 different scenarios:

  1. AMTM config file not set up or not found:

MerlinAU_WebGUI_EmailNotify#1

  1. AMTM config file OK and "Email Notifications" option is disabled:

MerlinAU_WebGUI_EmailNotify#2

  1. AMTM config file OK and "Email Notifications" option is enabled:

MerlinAU_WebGUI_EmailNotify#3

Please take test & validate when you have some time.

@ExtremeFiretop
Copy link
Owner

@ExtremeFiretop,

This PR now handles the issue you found WRT the AMTM config file not found & disabling the associated email notification parameters on the WebGUI page. Here are some screenshots showing 3 different scenarios:

  1. AMTM config file not set up or not found:

MerlinAU_WebGUI_EmailNotify#1

  1. AMTM config file OK and "Email Notifications" option is disabled:

MerlinAU_WebGUI_EmailNotify#2

  1. AMTM config file OK and "Email Notifications" option is enabled:

MerlinAU_WebGUI_EmailNotify#3

Please take test & validate when you have some time.

I like the distinction between the AMTM config file not found, and found but option is disabled.
My original logic didn't account for this I don't think... Will test and advise back shortly!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Jan 29, 2025

@Martinski4GitHub

Oh yeah, you got the magic my friend, works exactly as expected now:

Email function missing:

image

And email function configured but disabled:

image

@ExtremeFiretop ExtremeFiretop merged commit e726fc0 into ExtremeFiretop:WebFun Jan 29, 2025
1 check passed
@ExtremeFiretop
Copy link
Owner

@Martinski4GitHub

Merged! Works as advertised! And resolves the reported issues/bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants