Improvements for Updating to 1.4.0 WebGUI Version

[Martinski4GitHub]

• Various code improvements and fine-tuning for updating to the latest 1.4.0 WebGUI version.
  The goal is to allow for a "smooth transition" from the previous 1.3.10 to the new 1.4.0 version with WebGUI support.

• Fixed error with "Toggle F/W Build Type" menu option
  A "buildtypechoice: parameter not set" error was found when using the CLI menu option to "Toggle F/W Build Type" and the user presses only the <ENTER> key.

[Martinski4GitHub]

@ExtremeFiretop,

Sunday evening, my friend reported the "buildtypechoice: parameter not set" error he initially found in the latest 1.4.10 version that he was testing with, and then he also found the same error in the 1.3.9 and 1.3.10 versions. It seems this bug has probably been there for over a year now, but I guess very few users have ROG or TUF routers, and of those users, no one has simply pressed the <ENTER> key for the selection.

Here's the screenshot that my friend sent me when testing the latest 1.4.10 version:

And here's the screenshot when testing the latest 1.3.10 version:

I've submitted fixes for both versions on their respective PRs. My friend allowed me to remotely connect to his GT router via OpenVPN while implementing the fixes so I could then test & validate. BTW, the same bug is found for TUF routers as well.

[TheS1R]

@ExtremeFiretop,

Sunday evening, my friend reported the "buildtypechoice: parameter not set" error he initially found in the latest 1.4.10 version that he was testing with, and then he also found the same error in the 1.3.9 and 1.3.10 versions. It seems this bug has probably been there for over a year now, but I guess very few users have ROG or TUF routers, and of those users, no one has simply pressed the <ENTER> key for the selection.

Here's the screenshot that my friend sent me when testing the latest 1.4.10 version:

And here's the screenshot when testing the latest 1.3.10 version:

I've submitted fixes for both versions on their respective PRs. My friend allowed me to remotely connect to his GT router via OpenVPN while implementing the fixes so I could then test & validate. BTW, the same bug is found for TUF routers as well.

@Martinski4GitHub

Kudos to your friend for reporting and you for fixing this bug that was so obvious, yet so hidden. I was able to verify your fix on mt GT-BE98 Pro with latst v1.4.0 as well.

[ExtremeFiretop]

@Martinski4GitHub

Yes nice catch!

It's due to the:

[ -z "$choice" ] && break

Which to the best of my knowledge has been there a VERY long time. Surprised no one has reported this one yet!

[ExtremeFiretop]

@Martinski4GitHub

It's been this way since version 1.0.4 LOL
Here is my PR where the bug was added: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/128/files

So it's existed for the last 31 releases! :D Amazing catch by your friend.

[ExtremeFiretop]

@Martinski4GitHub

Considering the tests went well between 1.3.10 and 1.4.0
Are we ready to send out 1.3.10? Let me know what your thinking :)

[Martinski4GitHub]

@Martinski4GitHub

Considering the tests went well between 1.3.10 and 1.4.0 Are we ready to send out 1.3.10? Let me know what your thinking :)

Yeah, I think we are almost there. Let me look at my to-do list again to make sure.
AFAICR, the only test I have not yet completed is switching from the 'master' branch (v1.3.10) to the 'develop' branch (v1.4.0). I'd like to double-check that once the Beta version is announced, users can easily switch with the following command:

/jffs/scripts/MerlinAU.sh develop

Give me ~30 minutes to put things in place and then test & validate.

[ExtremeFiretop]

@Martinski4GitHub
Considering the tests went well between 1.3.10 and 1.4.0 Are we ready to send out 1.3.10? Let me know what your thinking :)

Yeah, I think we are almost there. Let me look at my to-do list again to make sure. AFAICR, the only test I have not yet completed is switching from the 'master' branch (v1.3.10) to the 'develop' branch (v1.4.0). I'd like to double-check that once the Beta version is announced, users can easily switch with the following command:

/jffs/scripts/MerlinAU.sh develop

Give me ~30 minutes to put things in place and then test & validate.

Take your time!

[Martinski4GitHub]

@Martinski4GitHub
Considering the tests went well between 1.3.10 and 1.4.0 Are we ready to send out 1.3.10? Let me know what your thinking :)

Yeah, I think we are almost there. Let me look at my to-do list again to make sure. AFAICR, the only test I have not yet completed is switching from the 'master' branch (v1.3.10) to the 'develop' branch (v1.4.0). I'd like to double-check that once the Beta version is announced, users can easily switch with the following command:

/jffs/scripts/MerlinAU.sh develop

I have now validated that using the above command to switch from the master (v1.3.10) to the developer (v1.4.0) branch is working well.

I have nothing else to test with or add to the 1.3.10 version so whenever you're ready, you can issue the production release.

[ExtremeFiretop]

@Martinski4GitHub
Considering the tests went well between 1.3.10 and 1.4.0 Are we ready to send out 1.3.10? Let me know what your thinking :)

Yeah, I think we are almost there. Let me look at my to-do list again to make sure. AFAICR, the only test I have not yet completed is switching from the 'master' branch (v1.3.10) to the 'develop' branch (v1.4.0). I'd like to double-check that once the Beta version is announced, users can easily switch with the following command:

/jffs/scripts/MerlinAU.sh develop

I have now validated that using the above command to switch from the master (v1.3.10) to the developer (v1.4.0) branch is working well.

I have nothing else to test with or add to the 1.3.10 version so whenever you're ready, you can issue the production release.

I'll do that tomorrow morning!
Thanks Martinski! Have a great night buddy!