Merged
Conversation
- Modified messaging regarding ROG & TUF build type preferences in order to improve user experience on small screen displays (e.g. SSH terminal session on an iPhone or iPad). - Added a tooltip (AKA hint msg) to the WebGUI "F/W Build Type Preference" title; this is in addition to the already existing alert msg. The goal is to give users enough "warning" about how the ROG/TUF build type selection works. _Miscellaneous code improvements.
Collaborator
Author
|
This PR includes some minor changes in messaging for ROG/TUF warnings/notices so that they show better in small-screen displays. Here's an example from my iPad on a remote SSH session connected to my friend's GT-AX6000:
Here's another screenshot of the WebGUI page showing the tooltip for the ROG build type:
|
ExtremeFiretop
approved these changes
Feb 19, 2025
Owner
|
Good to go! |
| /**-------------------------------------**/ | ||
| /** Added by Martinski W. [2025-Feb-18] **/ | ||
| /**-------------------------------------**/ | ||
| const ROG_BuildTypeMsg = 'The ROG build type preference will apply only if a compatible ROG firmware image is available. Otherwise, the Pure Non-ROG build will be used instead.'; |
Owner
There was a problem hiding this comment.
Approving the split messaging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified messaging regarding ROG & TUF build type preferences in order to improve user experience on small-screen displays (e.g. SSH terminal session on a tablet).
Added a tooltip (AKA hint msg) to the WebGUI "F/W Build Type Preference" title; this is in addition to the already existing alert msg. The goal is to give users enough "warning" about how the ROG/TUF build type selection works.
Miscellaneous code improvements.