Fix WebUI Changelog Check Approval#413
Conversation
Fix WebUI Changelog Check Approval
| ;; | ||
| "${SCRIPT_NAME}approvechangelog") | ||
| local currApprovalStatus="$(Get_Custom_Setting "FW_New_Update_Changelog_Approval")" | ||
| currApprovalStatus="$(Get_Custom_Setting "FW_New_Update_Changelog_Approval")" |
There was a problem hiding this comment.
This is a fix, with the "local" it didn't work correctly.
| Update_Custom_Settings "FW_New_Update_Changelog_Approval" "BLOCKED" | ||
| fi | ||
| ;; | ||
| "${SCRIPT_NAME}blockchangelog") |
There was a problem hiding this comment.
Net-new logic for review.
ExtremeFiretop
added
bug
|
This was the last thing on my to-do list to test and review (the Changelog approval) After the small bug fix and additional logic I'm happy with it's behavior. Please review whenever you get a chance and advise. Once this is merged in I think we are officially ready for beta testing on my side! |
Yeah, I think now we're down to the last couple of "touch-ups" to make the Beta release as good as we can make it at this point. I have nothing else on my to-do list, but I'm waiting for my friend to do his validation & report back with feedback. |
Ah okay, no worries! We shall wait and see if anyone finds anything else! |
2 participants
Hey @Martinski4GitHub
Recently reviewed the changelog approval status code and noticed a bug which I fixed below.
Also wanted to change some of the behavior of the WebUI button so I added some new logic.
Below is examples of everything working as expected:
High risk detected on script load (as normal):
WebUI detects blocked changelog to approve:
Once approved, we give the option to block again (same as the core shell script):
