Improvements & Enhancements#415
Conversation
1) Increased sleep time to 15 seconds after removing 3rd-party cron jobs to allow already started cron jobs to complete execution. Most cron jobs finish in a couple of seconds, but a few may require more time, especially those dealing with SQL database operations (e.g. uiDivStats, connmon, spdmerlin, ntpmerlin, vnStats) so allowing more time can prevent corrupting the database/CSV files if the operation is abruptly interrupted. 2) Added commands just *before* removing/unmounting the USB drives to make sure that any existing I/O blocks currently buffered/cached are flushed and written out safely to the USB drives. 3) Added Wiki page URL to CLI "Help" and "About" information displayed. 4) Added Wiki URL hyperlink to WebGUI page. 5) Added tooltip to "Enable Auto-Updates for MerlinAU" option.
|
Please review this latest PR whenever you have time. No fixes, just a couple of enhancements and some improvements in messaging, including adding the Wiki URL in 3 separate places for more visibility, especially to help any new users who may have questions or need clarification so we can point them to the Wiki URL. |
Your great! I just quickly reviewed the code and it's nothing crazy, I could just merge now, but I'll still wait until the morning to test before merging! Thank you Martinski! I like the idea to put the Wiki is more places that people can find our answers to common questions. I did recently update the Wiki a few days ago, but I still plan to update it some more when we merge in 1.4.0 |
Yeah, no worries, take your time. There's no rush. We still have one more week to make & review these "touch-ups" for the initial Beta public release. I'm sure a few other things may need our attention based on user feedback. BTW, my friend mentioned that, so far, his testing is going very well, and he "really loved" all the tooltips as well!! He's going to provide me with his validation results and any recommendations either Sunday or Monday evening. I value his input because he's very professional in his work and assessments, and he doesn't simply "phone it in."
That sounds good. Now that the Wiki page will have more visibility with the 1.4.0 release, I will try to take a look and review it as well in case I may want to add some clarification on some questions. Have a good night, buddy!! |
Sounds good to me my friend! Goodnight buddy! |
|
Tested your changes on my node while flashing the latest alpha for my GT-AXE11000 and all worked very well! Both a test of the extra delay, as well as a node test for the latest code :) |
2 participants
Increased sleep time to 15 seconds after removing 3rd-party cron jobs to allow already started cron jobs to complete execution. Most cron jobs finish in a couple of seconds, but a few may require more time, especially those dealing with background SQL database operations (e.g. uiDivStats, connmon, spdmerlin, ntpmerlin, vnStats) so allowing more time can prevent corrupting the database/CSV files if the operation is abruptly interrupted.
Added commands just before removing/unmounting the USB drives to make sure that any existing I/O blocks currently buffered/cached are flushed and written out safely to the USB drives.
Added Wiki page URL to CLI "Help" and "About" information displayed.
Added Wiki URL hyperlink to WebGUI page.
Added tooltip to "Enable Auto-Updates for MerlinAU" option.
Sample screenshots for the UI changes: