Skip to content

UI Improvements#416

Merged
ExtremeFiretop merged 2 commits intoExtremeFiretop:WebFunfrom
Martinski4GitHub:WebFun
Feb 26, 2025
Merged

UI Improvements#416
ExtremeFiretop merged 2 commits intoExtremeFiretop:WebFunfrom
Martinski4GitHub:WebFun

Conversation

@Martinski4GitHub
Copy link
Collaborator

  1. Added "Directory for F/W Update Log File" option on the WebGUI page.

  2. More tooltips to help clarify options:

    • Directory for F/W Update File
    • Directory for F/W Update Log File
    • Beta-to-Release F/W Updates
    • Tailscale/ZeroTier VPN Access
  3. Code improvements and fine-tuning.

Sample UI Screenshots:

MerlinAU_v1 4 0 _WebGUI_Hint01

MerlinAU_v1 4 0 _WebGUI_Hint02

MerlinAU_v1 4 0 _WebGUI_Hint03

MerlinAU_v1 4 0 _WebGUI_Hint04

1) Added "Directory for F/W Updage Log File" option on the WebGUI page.

2) More tooltips to help clarify options:
   - Directory for F/W Update File
   - Directory for F/W Updage Log File
   - Beta-to-Release F/W Updates
   - Tailscale/ZeroTier VPN Access

5) More code improvements and fine-tuning.
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,

Sunday night, my friend sent me his feedback after testing the 1.4.0 WebGUI version, and he had a suggestion to add the option on the WebGUI (as in the CLI menu) to set the "Directory for F/W Update Log Files."

I had planned to add this option later on (perhaps after Beta was announced and while it was being tested for user feedback), but I just went ahead last night anyway since a lot of the code was already there to handle the directory path for F/W updates, but had to be modified to handle 2 directory entries. AFAIK, this is really the last major feature that was "missing" from the 1.4.0 WebGUI page.

Anyway, please review and validate this PR when you have time, especially the modified code handling the setting and checking of the 2 separate directory paths. This evening, I tested as much as I could, but I need your 2nd pair of eyes to "keep me honest." :>)

There's no rush so take your time. We can always delay the Beta announcement for a few days if we get busy with other things since we never publicly committed to a specific date, so we have flexibility.

Have a good night, bud!!!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Feb 25, 2025

Sample UI Screenshots:

MerlinAU_v1 4 0 _WebGUI_Hint01

@Martinski4GitHub

I really like this, any thoughts on adding the default paths for both USB and local directories in the tool tip?
Incase it gets reset or the user changes it and wants to change it back, could be handy to reference the 2 "default" locations:

(tmp/mnt and /home/root)

@ExtremeFiretop
Copy link
Owner

@Martinski4GitHub

I should add I really like the additional tooltips, all is really good there!
Also like the idea of the log directory being added, honestly I totally forgot about that, so if it was on your to-list your better than I.

I would of waited until someone reported it missing LOL

@TheS1R
Copy link

TheS1R commented Feb 25, 2025

@ExtremeFiretop,

Sunday night, my friend sent me his feedback after testing the 1.4.0 WebGUI version, and he had a suggestion to add the option on the WebGUI (as in the CLI menu) to set the "Directory for F/W Update Log Files."

I had planned to add this option later on (perhaps after Beta was announced and while it was being tested for user feedback), but I just went ahead last night anyway since a lot of the code was already there to handle the directory path for F/W updates, but had to be modified to handle 2 directory entries. AFAIK, this is really the last major feature that was "missing" from the 1.4.0 WebGUI page.

Anyway, please review and validate this PR when you have time, especially the modified code handling the setting and checking of the 2 separate directory paths. This evening, I tested as much as I could, but I need your 2nd pair of eyes to "keep me honest." :>)

There's no rush so take your time. We can always delay the Beta announcement for a few days if we get busy with other things since we never publicly committed to a specific date, so we have flexibility.

Have a good night, bud!!!

I love all of the recent tool tips, cleanups, and enhancements.

With the addition of option to set the "Directory for F/W Update File", I believe that you might have created a bit of confusion/conflict with the script version:

  • web UI shows only the path to the USB drive (for me, /tmp/mnt/bckupTheS1R)
  • Advanced Options, option 1 in script includes the subdirectory as well (for me, /tmp/mnt/bckupTheS1R/MerlinAU.d/GT-BE98_PRO_firmware)

When entering Advanced Options, option 1 in script, the user is prompted for the Current Base Path. You may want to consider making these two consistent. Simply changing the label in the web UI would be all that is necessary.

More improvements and fine-tuning WRT messaging.
@Martinski4GitHub
Copy link
Collaborator Author

Sample UI Screenshots:

@Martinski4GitHub

I really like this, any thoughts on adding the default paths for both USB and local directories in the tool tip? Incase it gets reset or the user changes it and wants to change it back, could be handy to reference the 2 "default" locations:

(tmp/mnt and /home/root)

I just submitted some changes to the tooltips for the directory paths:

MerlinAU_v1 4 0 _WebGUI_Hint01

MerlinAU_v1 4 0 _WebGUI_Hint02

Check out the modified tooltip above for the "Directory for F/W Update File" option.
Is that what you had in mind to show a "default path" based on the current user's configuration?

@Martinski4GitHub
Copy link
Collaborator Author

I love all of the recent tool tips, cleanups, and enhancements.

With the addition of option to set the "Directory for F/W Update File", I believe that you might have created a bit of confusion/conflict with the script version:

The option "Directory for F/W Update File" was already on the WebGUI from the beginning, so I assume you meant the new "Directory for F/W Update Log File" option (for the LOG files).

* web UI shows only the path to the USB drive (_for me,_ **/tmp/mnt/bckupTheS1R**)

Yeah, that's the intended behavior for the expected user input.

* **Advanced Options**, option 1 in script includes the subdirectory as well (_for me,_ **/tmp/mnt/bckupTheS1R/MerlinAU.d/GT-BE98_PRO_firmware**)

The full path is shown only when simply viewing the menu options. However, when the user selects the input dialog screen, only the base path is shown (same as the WebGUI) since that's the expected input format from the user.

When entering Advanced Options, option 1 in script, the user is prompted for the Current Base Path. You may want to consider making these two consistent. Simply changing the label in the web UI would be all that is necessary.

How about the newly modified tooltips from my latest changes?
Does that work for you?

@TheS1R
Copy link

TheS1R commented Feb 26, 2025

I love all of the recent tool tips, cleanups, and enhancements.
With the addition of option to set the "Directory for F/W Update File", I believe that you might have created a bit of confusion/conflict with the script version:

The option "Directory for F/W Update File" was already on the WebGUI from the beginning, so I assume you meant the new "Directory for F/W Update Log File" option (for the LOG files).

* web UI shows only the path to the USB drive (_for me,_ **/tmp/mnt/bckupTheS1R**)

Yeah, that's the intended behavior for the expected user input.

* **Advanced Options**, option 1 in script includes the subdirectory as well (_for me,_ **/tmp/mnt/bckupTheS1R/MerlinAU.d/GT-BE98_PRO_firmware**)

The full path is shown only when simply viewing the menu options. However, when the user selects the input dialog screen, only the base path is shown (same as the WebGUI) since that's the expected input format from the user.

When entering Advanced Options, option 1 in script, the user is prompted for the Current Base Path. You may want to consider making these two consistent. Simply changing the label in the web UI would be all that is necessary.

How about the newly modified tooltips from my latest changes? Does that work for you?

Yes, updated tooltips definitely clarify! Just hope that users use AND READ tooltips — I know, I'm dreaming.

Amazing cleanup work on an already great product, @Martinski4GitHub!

@ExtremeFiretop ExtremeFiretop merged commit 569ff8a into ExtremeFiretop:WebFun Feb 26, 2025
1 check passed
@ExtremeFiretop
Copy link
Owner

@Martinski4GitHub

Good to go!

@ExtremeFiretop
Copy link
Owner

@Martinski4GitHub

Seems we are already getting some feedback, have yet to try to replicate any of it but it sounds odd to me.

@Martinski4GitHub
Copy link
Collaborator Author

@Martinski4GitHub

Seems we are already getting some feedback, have yet to try to replicate any of it but it sounds odd to me.

Yeah, I saw the feedback. The "TBD" in the field is easy to fix so I just submitted a PR.
I have a few minutes before I go to bed, so I'll take a look at the code and try to replicate the issue with the "Postponement Days" option. Very odd indeed.

@ExtremeFiretop
Copy link
Owner

@Martinski4GitHub
Seems we are already getting some feedback, have yet to try to replicate any of it but it sounds odd to me.

Yeah, I saw the feedback. The "TBD" in the field is easy to fix so I just submitted a PR. I have a few minutes before I go to bed, so I'll take a look at the code and try to replicate the issue with the "Postponement Days" option. Very odd indeed.

I literally have 2 hours before I'm supposed to be awake again LOL; whoot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants