Skip to content

Fix The Update Check Status Post Upgrade#418

Merged
Martinski4GitHub merged 2 commits intodevfrom
ExtremeFiretop-Fix-UpdateCheck
Mar 2, 2025
Merged

Fix The Update Check Status Post Upgrade#418
Martinski4GitHub merged 2 commits intodevfrom
ExtremeFiretop-Fix-UpdateCheck

Conversation

@ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented Mar 1, 2025

Fix The Update Check Status Post Upgrade in the WebUI

Issue seems to be it does not check or set the FW_UPDATE_CHECK value in the settings file post upgrade as seen below:

image

We should be seeing this run:

image

Which sets the value.

Solution seems to be to simply add the missing: ConfirmCronJobForFWAutoUpdates within the DoInstallation routine.
Without this, on first upgrade after running: sh /jffs/scripts/MerlinAU.sh develop

We get this result in the configuration file:

image

Simply running the script a second time also fixes the "bug" but we can add this to the Install routine I think without any impact.

Fix The Update Check Status Post Upgrade in the WebUI
@ExtremeFiretop ExtremeFiretop added the bug Something isn't working label Mar 1, 2025
@Martinski4GitHub
Copy link
Collaborator

Fix The Update Check Status Post Upgrade in the WebUI

Issue seems to be it does not check or set the FW_UPDATE_CHECK value in the settings file post upgrade as seen below:
...

We should be seeing this run:
....

Which sets the value.

Solution seems to be to simply add the missing: ConfirmCronJobForFWAutoUpdates within the DoInstallation routine.

Yeah, that should work just fine.

Without this, on first upgrade after running: sh /jffs/scripts/MerlinAU.sh develop

We get this result in the configuration file:

Simply running the script a second time also fixes the "bug" but we can add this to the Install routine I think without any impact.

Sounds good.

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@Martinski4GitHub Martinski4GitHub merged commit 43b3af1 into dev Mar 2, 2025
3 checks passed
@ExtremeFiretop
Copy link
Owner Author

Fix The Update Check Status Post Upgrade in the WebUI
Issue seems to be it does not check or set the FW_UPDATE_CHECK value in the settings file post upgrade as seen below:
...
We should be seeing this run:
....
Which sets the value.
Solution seems to be to simply add the missing: ConfirmCronJobForFWAutoUpdates within the DoInstallation routine.

Yeah, that should work just fine.

Without this, on first upgrade after running: sh /jffs/scripts/MerlinAU.sh develop
We get this result in the configuration file:
Simply running the script a second time also fixes the "bug" but we can add this to the Install routine I think without any impact.

Sounds good.

Now that's in dev; I'll just test it again! :)

@ExtremeFiretop
Copy link
Owner Author

@Martinski4GitHub

Bingo! Was his name-o! I now see the missing step when doing the update process:

image

And loading the WebUI right away shows "Enabled"

image

Thanks buddy for the review!

@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-Fix-UpdateCheck branch March 4, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants