Skip to content

WebGUI Functionality Improvement#419

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev
Mar 8, 2025
Merged

WebGUI Functionality Improvement#419
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub
Copy link
Collaborator

Added functionality to the WebGUI so that users can optionally select to run a "Router Login Test" when saving the password to verify that the login credentials are indeed valid. This is similar to the option available in the CLI menu where users can select to run the same router login test.

Added functionality to the WebGUI so that users can optionally select to run a "Router Login Test" when saving the password to verify that the login credentials are indeed valid. This is similar to the option available in the CLI menu where users can select to run the same router login test.
@Martinski4GitHub Martinski4GitHub changed the title WebGUI Funtionality Improvement WebGUI Functionality Improvement Mar 8, 2025
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,

Whenever you have time, Please review and validate the new functionality added with this PR.

Here is the general workflow:

  1. When users first start the WebGUI, they'll see an "UNKNOWN" status for the password field because the code doesn't know whether the password is valid (even if the user knows it is in fact valid).

MerlinAU_v1 4 0 _WebGUI_Unknown

  1. The user can select the option to "Run login test when saving password" by clicking on the checkbox below the password field (default is always unchecked). Upon selection, the user gets an alert pop-up window explaining that the login test will log them out of the WebGUI, so the user must confirm the selection.

MerlinAU_v1 4 0 _WebGUI_Notice

  1. If the "Router Login Test" checkbox is selected when the user clicks on the "Save" button for that section, the normal process starts but after ~10 secs, the user is automatically logged out of the WebGUI.

  2. When the user logs back into the WebGUI, they are presented with 2 possible status results:

    a) Password in INVALID because the login test failed:

MerlinAU_v1 4 0 _WebGUI_Error

MerlinAU_v1 4 0 _WebGUI_Invalid

 b) Password in VERIFIED because the login test was successful.

MerlinAU_v1 4 0 _WebGUI_Verified

  1. OTOH, if the user does NOT select to run the "Router Login Test" before saving the password, the normal "Save" process occurs and when completed, the user will see the "NOT verified" status for the password field. This status will remain until the user selects to run the Router Login Test to verify the credentials.

MerlinAU_v1 4 0 _WebGUI_NotVerified

  1. Here's the tooltip showing the username that is used with the password to run the login test. This is useful in cases where sometimes the username value gets corrupted in NVRAM.

MerlinAU_v1 4 0 _WebGUI_Tooltip

Let me know if this new functionality works well for you.

@TheS1R
Copy link

TheS1R commented Mar 8, 2025

@ExtremeFiretop,

Whenever you have time, Please review and validate the new functionality added with this PR.

Here is the general workflow:

  1. When users first start the WebGUI, they'll see an "UNKNOWN" status for the password field because the code doesn't know whether the password is valid (even if the user knows it is in fact valid).

MerlinAU_v1 4 0 _WebGUI_Unknown

  1. The user can select the option to "Run login test when saving password" by clicking on the checkbox below the password field (default is always unchecked). Upon selection, the user gets an alert pop-up window explaining that the login test will log them out of the WebGUI, so the user must confirm the selection.

MerlinAU_v1 4 0 _WebGUI_Notice

  1. If the "Router Login Test" checkbox is selected when the user clicks on the "Save" button for that section, the normal process starts but after ~10 secs, the user is automatically logged out of the WebGUI.
  2. When the user logs back into the WebGUI, they are presented with 2 possible status results:
    a) Password in INVALID because the login test failed:

MerlinAU_v1 4 0 _WebGUI_Error

MerlinAU_v1 4 0 _WebGUI_Invalid

 b) Password in VERIFIED because the login test was successful.

MerlinAU_v1 4 0 _WebGUI_Verified

  1. OTOH, if the user does NOT select to run the "Router Login Test" before saving the password, the normal "Save" process occurs and when completed, the user will see the "NOT verified" status for the password field. This status will remain until the user selects to run the Router Login Test to verify the credentials.

MerlinAU_v1 4 0 _WebGUI_NotVerified

  1. Here's the tooltip showing the username that is used with the password to run the login test. This is useful in cases where sometimes the username value gets corrupted in NVRAM.

MerlinAU_v1 4 0 _WebGUI_Tooltip

Let me know if this new functionality works well for you.

@Martinski4GitHub, FANTASTIC implementation!

@ExtremeFiretop ExtremeFiretop merged commit ad44793 into ExtremeFiretop:dev Mar 8, 2025
2 checks passed
@ExtremeFiretop
Copy link
Owner

Good to go!

Absolutely beautiful @Martinski4GitHub !!

Love the additon!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Mar 8, 2025

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants