Skip to content

Minor Cleanup#422

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev
Mar 11, 2025
Merged

Minor Cleanup#422
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub
Copy link
Collaborator

Some minor changes to get "clean" code via the Linter tool.

Some minor changes to get "clean" code via the Linter tool.
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,

This PR has only minor changes to keep the code "clean" when running the Linter tool.
Nothing critical so please review whenever you get a chance.
So far so good, we have some really nice & "clean" code.

@ExtremeFiretop
Copy link
Owner

@Martinski4GitHub

I was just about to head to bed my friend, but as always I appreciate you running our latest code through the linter tool.

Never once had that came out with something worse than it was, so I'm sure this is great but because I'm just so tired tonight (was a long day catching up at work) I'm going to push this review until tomorrow sometime.

I don't want to risk making anymore dumb mistakes while doing a review 😜
Goodnight bud

@Martinski4GitHub
Copy link
Collaborator Author

@Martinski4GitHub

I was just about to head to bed my friend, but as always I appreciate you running our latest code through the linter tool.

Never once had that came out with something worse than it was, so I'm sure this is great but because I'm just so tired tonight (was a long day catching up at work) I'm going to push this review until tomorrow sometime.

I don't want to risk making anymore dumb mistakes while doing a review 😜 Goodnight bud

Oh yeah, take your time. There's nothing urgent on this PR so whenever you have time.

We're doing really well with keeping our code "clean" (no errors at all, only some minor warnings & a few false positives), so I like to run the Linter tool at least every 2 weeks just to make sure we're on top of it.

Have a good night, bud!!

@ExtremeFiretop
Copy link
Owner

Approved and good to go!

@ExtremeFiretop ExtremeFiretop merged commit d3ca507 into ExtremeFiretop:dev Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants