Skip to content

Fixes and Improvements.#433

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:mainfrom
Martinski4GitHub:main
Mar 29, 2025
Merged

Fixes and Improvements.#433
ExtremeFiretop merged 1 commit intoExtremeFiretop:mainfrom
Martinski4GitHub:main

Conversation

@Martinski4GitHub
Copy link
Collaborator

  • Fixed a bug where the version.txt file was being replaced prematurely.
  • Fixed a bug where the wrong parameter value for URL was being returned.
  • Some code improvements.

- Fixed a bug where the version file was being replaced prematurely.
- Fixed a bug where the wrong parameter value for URL was being returned.
- Code improvements.
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,

This PR includes the fix so that the version file is no longer replaced when doing a "script update" check.
Also, there's a fix in the GetLatestFirmwareMD5URL() function which was returning the wrong parameter for URL.

BTW, this morning, I just ran both scripts (from the master and develop branches) through the Linter tool, and they came out "clean." Last night, I was too tired by the time I had finished the code changes, so I waited until this morning to do it before submitting the PRs.

@ExtremeFiretop
Copy link
Owner

@Martinski4GitHub

This is the only review before going to production so excuse the spam as I go through everything.

@ExtremeFiretop
Copy link
Owner

Forms post update = READY
Readme update = COMPLETED
Version.txt update = COMPLETED

Dev 1.3.12 as Next Stable Release

What's Changed/Fixed?:

PR: #433

  1. Fixed a bug where the version.txt file was being replaced prematurely.
  2. Fixed a bug where the wrong parameter value for URL was being returned.
  3. Some code improvements.

@ExtremeFiretop ExtremeFiretop merged commit d378fb1 into ExtremeFiretop:main Mar 29, 2025
1 check failed
@Martinski4GitHub
Copy link
Collaborator Author

@Martinski4GitHub

This is the only review before going to production so excuse the spam as I go through everything.

Of course!! I expect nothing less :>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants