Skip to content

Fixed WebGUI Cron Schedule Days#435

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev
Mar 30, 2025
Merged

Fixed WebGUI Cron Schedule Days#435
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub
Copy link
Collaborator

Removed extra spaces in the WebGUI Cron Schedule Days, which caused the last day (Sat) to fall on the next line.

Removed extra spaces in the WebGUI Cron Schedule Days which caused the last day (SAT) to fall on the next line.
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,

This PR fixes the WebGUI issue reported on the SNB Forums here:

https://www.snbforums.com/threads/merlinau-v1-3-12-the-ultimate-firmware-auto-updater-gnuton-support.91326/page-9#post-949767

@ExtremeFiretop
Copy link
Owner

I literally don't have the issue he's showing.
I'm not sure how to test, did you have the issue?

@Martinski4GitHub
Copy link
Collaborator Author

I literally don't have the issue he's showing. I'm not sure how to test, did you have the issue?

No, I don't have the issue on the WebGUI, but you can clearly see in his screenshot that the root cause is the extra spaces introduced in PR #428, where you changed the layout for a single "Save" button. It may be that his screen monitor has lower resolution on the horizontal plane, so there are fewer pixels to accommodate the extra spaces. If you want, you could ask the user to test & verify the fix.

P.S. My wife is calling me. Hold my beer... :>)

@ExtremeFiretop ExtremeFiretop merged commit eb39050 into ExtremeFiretop:dev Mar 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants