Code Improvements

[Martinski4GitHub]

Code improvements when parsing the F/W Update cron schedule to show a human-readable form and select valid "days of week" in the WebGUI page.

[Martinski4GitHub]

@ExtremeFiretop,

Some more code improvements for the cron schedule to make sure only valid values are found when parsing in both the CLI menu and WebGUI page.

[ExtremeFiretop]

Code improvements when parsing the F/W Update cron schedule to show a human-readable form and select valid "days of week" in the WebGUI page.

Just as my girl woke me up! Nice timing!

[Martinski4GitHub]

BTW,

This PR takes care of this (from user "vlord" screenshot):

Schedule: 3:00 AM, on 0, every month

I should now be displayed as:

Schedule: 3:00 AM, on Sun, every month

[ExtremeFiretop]

BTW,

This PR takes care of this (from user "vlord" screenshot):

Schedule: 3:00 AM, on 0, every month

I should now be displayed as:

Schedule: 3:00 AM, on Sun, every month

Yes I had noticed that, but frankly because you had mentioned in your PR for that implementation more advanced crons would show as "empty"

I basically knew what the reason was, he clearly was using a more advanced cron so I wasn't overly concerned about the displayed information for him

[ExtremeFiretop]

I would however like an answer in regards to why his Changelog approval wasn't grayed out.

Also in his screenshot it says undefined for the grayed out email field.

[Martinski4GitHub]

BTW,
This PR takes care of this (from user "vlord" screenshot):

Schedule: 3:00 AM, on 0, every month

I should now be displayed as:

Schedule: 3:00 AM, on Sun, every month

Yes I had noticed that, but frankly because you had mentioned in your PR for that implementation more advanced crons would show as "empty"

I basically knew what the reason was, he clearly was using a more advanced cron so I wasn't overly concerned about the displayed information for him

That's what it seems at first, but after a 2nd look, his cron schedule was actually very simple:

0  3  *  *  0

So the code should be able to parse it and show the correct human-readable string.

[Martinski4GitHub]

I would however like an answer in regards to why his Changelog approval wasn't grayed out.

Yes, that part is strange.

Also in his screenshot it says undefined for the grayed out email field.

Yeah, I saw that; however, since it's grayed out, showing "undefined" might not necessarily be a bad idea.
I am wondering, though, what value he currently has in his configuration file.

[ExtremeFiretop]

BTW,
This PR takes care of this (from user "vlord" screenshot):

Schedule: 3:00 AM, on 0, every month

I should now be displayed as:

Schedule: 3:00 AM, on Sun, every month

Yes I had noticed that, but frankly because you had mentioned in your PR for that implementation more advanced crons would show as "empty"
I basically knew what the reason was, he clearly was using a more advanced cron so I wasn't overly concerned about the displayed information for him

That's what it seems at first, but after a 2nd look, his cron schedule was actually very simple:

0  3  *  *  0

So the code should be able to parse it and show the correct human-readable string.

Ah your right, I was expecting him to be using days of the month but your right, on a second look it seems pretty simple. Hopefully he gets to test this out and report back then!

[ExtremeFiretop]

To be specific I meant I expected him to be using a specific list of days of month

[Martinski4GitHub]

To be specific I meant I expected him to be using a specific list of days of month

Yeah, that's what he implied by getting "monthly updates" but then his cron job did not reflect that.

Frankly, I find that a lot of his posts lack clarity, precision & details, so one has to try to "interpret" what we think he's trying to say, which often leads to confusion or misunderstandings.

[Martinski4GitHub]

To be specific I meant I expected him to be using a specific list of days of month

Yeah, that's what he implied by getting "monthly updates" but then his cron job did not reflect that.

Frankly, I find that a lot of his posts lack clarity, precision & details, so one has to try to "interpret" what we think he's trying to say, which often leads to confusion or misunderstandings.

OTOH, to his credit, at least this time he provided very good screenshots, and those helped a lot to get some understanding of what he's saying...

[ExtremeFiretop]

To be specific I meant I expected him to be using a specific list of days of month

Yeah, that's what he implied by getting "monthly updates" but then his cron job did not reflect that.

Exactly.

Frankly, I find that a lot of his posts lack clarity, precision & details, so one has to try to "interpret" what we think he's trying to say, which often leads to confusion or misunderstandings.

I feel the same way, I often have to poke for clarification because it's not clear.
I'm happy it's not just me, I realize I'm not perfect either I can sometimes miss on an important detail that frames what I mean, as dyslexic guy I try, I really do hahahaha 🤣

But I think it would be ideal if vlord would lead with screenshots (for example, of his configuration file or cron schedules as seen in the cru command) and then try to backfill what he's showing us. But the small posts with little detail leave me hanging lots of the time.

I find when I start with a screenshot and backfill the story, I have greater success explaining myself and it also sparks points I would of otherwise forgot. Plus anything I don't mention usually the screenshot will help. As they say, a picture is worth a thousand words.

[Martinski4GitHub]

To be specific I meant I expected him to be using a specific list of days of month

Yeah, that's what he implied by getting "monthly updates" but then his cron job did not reflect that.

Exactly.

Frankly, I find that a lot of his posts lack clarity, precision & details, so one has to try to "interpret" what we think he's trying to say, which often leads to confusion or misunderstandings.

I feel the same way, I often have to poke for clarification because it's not clear. I'm happy it's not just me, I realize I'm not perfect either I can sometimes miss on an important detail that frames what I mean, as dyslexic guy I try, I really do hahahaha 🤣

But I think it would be ideal if vlord would lead with screenshots (for example, of his configuration file or cron schedules as seen in the cru command) and then try to backfill what he's showing us. But the small posts with little detail leave me hanging lots of the time.

I find when I start with a screenshot and backfill the story, I have greater success explaining myself and it also sparks points I would of otherwise forgot. Plus anything I don't mention usually the screenshot will help. As they say, a picture is worth a thousand words.

Yes, exactly. Even when we think our thoughts are written clearly and fully explain something, adding some relevant screenshots is always better and reinforces the written words on the page. Just like any other critical skill, effective communication takes effort at first, but the more we practice, the better we become at it.

[ExtremeFiretop]

Yes, exactly. Even when we think our thoughts are written clearly and fully explain something, adding some relevant screenshots is always better and reinforces the written words on the page. Just like any other critical skill, effective communication takes effort at first, but the more we practice, the better we become at it.

You've definitely helped develop my skills in that regard, not just on the coding front but on the communication front.

Lots of the time at work (as sure it's the same with you) it's just faster and easier to take a call. I know I once offered we did the same, instead we opted to remain text based which really put my skills to the test.

At work, an email isn't clear? You can bet 120% the next thing I'm doing is calling them on Microsoft Teams or on their cell phone and asking for clarification, here over GitHub and the forums that isn't an option.

[Martinski4GitHub]

Yes, exactly. Even when we think our thoughts are written clearly and fully explain something, adding some relevant screenshots is always better and reinforces the written words on the page. Just like any other critical skill, effective communication takes effort at first, but the more we practice, the better we become at it.

You've definitely helped develop my skills in that regard, not just on the coding front but on the communication front.

Lots of the time at work (as sure it's the same with you) it's just faster and easier to take a call. I know I once offered we did the same, instead we opted to remain text based which really put my skills to the test.

At work, an email isn't clear? You can beat 120% the next thing I'm doing is calling them on Microsoft Teams or on their cell phone and asking for clarification, here over GitHub and the forums that isn't an option.

At work, we are required to write down and leave an "online trail" on every major decision or direction that we take.

Even after a meeting, teleconference, or a phone call, if a major decision was made, or some action items were given, etc., the person has to write down his part and send it out to the team so everyone is aware of what's going on, and everyone is on the same page. In my previous job, it was basically the same. So I'm very used to writing down my thoughts, and try to be clear & precise; also, any relevant flowcharts, screenshots, diagrams, etc. are attached to make things easier to understand.

P.S.
Going offline now, bud!! Have a good day. Talk to you later.