Skip to content

Code Cleanup & Improvements#439

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev
Apr 3, 2025
Merged

Code Cleanup & Improvements#439
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub
Copy link
Collaborator

Just some cleanup & improvements.

Just some cleanup & improvements.
@ExtremeFiretop ExtremeFiretop merged commit bbd0e23 into ExtremeFiretop:dev Apr 3, 2025
1 check passed
@ExtremeFiretop
Copy link
Owner

Just some cleanup & improvements.

You will always be a true team player in my eyes Martinski.
Thanks again! Have a goodnight my friend. I'm going to catch some 💤😴

Thanks for all your help with this one

@Martinski4GitHub
Copy link
Collaborator Author

Just some cleanup & improvements.

You will always be a true team player in my eyes Martinski. Thanks again! Have a goodnight my friend. I'm going to catch some 💤😴

Thanks for all your help with this one

You're most welcome, bud!!
You've become a real "dev. partner" as well, and I fully appreciate your cooperative, hard-working, & friendly spirit.

BTW, I think this 1.4.0 release is pretty much ready for prime time!!
I don't know if you want to issue the production release just in time for the next 3004.388.9 F/W, which is currently in Beta.
I'm not in a rush, but at some point we have to bite the bullet, and let it rip!!! LOL!!!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Apr 6, 2025

BTW, I think this 1.4.0 release is pretty much ready for prime time!! I don't know if you want to issue the production release just in time for the next 3004.388.9 F/W, which is currently in Beta. I'm not in a rush, but at some point we have to bite the bullet, and let it rip!!! LOL!!!

I thought so as well; so I've just prepared the PR for merge:

#440

It needs your final review and approval, as well we need to draft a form post that properly describes the full release.

@Martinski4GitHub
Copy link
Collaborator Author

BTW, I think this 1.4.0 release is pretty much ready for prime time!! I don't know if you want to issue the production release just in time for the next 3004.388.9 F/W, which is currently in Beta. I'm not in a rush, but at some point we have to bite the bullet, and let it rip!!! LOL!!!

I thought so as well; so I've just prepared the PR for merge:

#440

Apologies for the delay. My wife and I just arrived home, coming back from my brother's birthday celebration, and I feel tired, so I'm going to bed early tonight to get some much-needed sleep.

It needs your final review and approval, as well we need to draft a form post that properly describes the full release.

OK, sounds good. I think there's not a lot that needs to be explained or described since the main purpose of the 1.4.0 release is to add the WebGUI page that supports existing functionality already available in the SSH CLI menus.

The only part that would need some clarification is the "F/W Update Checks" Cron Schedule on the WebGUI page, which, by design, does not offer the full "custom schedule" functionality available on the CLI menu.

@ExtremeFiretop
Copy link
Owner

BTW, I think this 1.4.0 release is pretty much ready for prime time!! I don't know if you want to issue the production release just in time for the next 3004.388.9 F/W, which is currently in Beta. I'm not in a rush, but at some point we have to bite the bullet, and let it rip!!! LOL!!!

I thought so as well; so I've just prepared the PR for merge:
#440

Apologies for the delay. My wife and I just arrived home, coming back from my brother's birthday celebration, and I feel tired, so I'm going to bed early tonight to get some much-needed sleep.

It needs your final review and approval, as well we need to draft a form post that properly describes the full release.

OK, sounds good. I think there's not a lot that needs to be explained or described since the main purpose of the 1.4.0 release is to add the WebGUI page that supports existing functionality already available in the SSH CLI menus.

The only part that would need some clarification is the "F/W Update Checks" Cron Schedule on the WebGUI page, which, by design, does not offer the full "custom schedule" functionality available on the CLI menu.

No worries we can do the release tomorrow buddy. Have a goodnight!
I'll think on the post for the forums on how I want to handle it, I think slamming everyone with a list of PRs may not be ideal 🤣

@Martinski4GitHub
Copy link
Collaborator Author

BTW, I think this 1.4.0 release is pretty much ready for prime time!! I don't know if you want to issue the production release just in time for the next 3004.388.9 F/W, which is currently in Beta. I'm not in a rush, but at some point we have to bite the bullet, and let it rip!!! LOL!!!

I thought so as well; so I've just prepared the PR for merge:
#440

Apologies for the delay. My wife and I just arrived home, coming back from my brother's birthday celebration, and I feel tired, so I'm going to bed early tonight to get some much-needed sleep.

It needs your final review and approval, as well we need to draft a form post that properly describes the full release.

OK, sounds good. I think there's not a lot that needs to be explained or described since the main purpose of the 1.4.0 release is to add the WebGUI page that supports existing functionality already available in the SSH CLI menus.
The only part that would need some clarification is the "F/W Update Checks" Cron Schedule on the WebGUI page, which, by design, does not offer the full "custom schedule" functionality available on the CLI menu.

No worries we can do the release tomorrow buddy. Have a goodnight!

Sounds good. Have a good night!!

I'll think on the post for the forums on how I want to handle it, I think slamming everyone with a list of PRs may not be ideal 🤣

Yes, exactly. Something "short and sweet" should be good enough!!! 😉
Most people don't even read the release notes carefully anyway, LOL!!!

@ExtremeFiretop
Copy link
Owner

BTW, I think this 1.4.0 release is pretty much ready for prime time!! I don't know if you want to issue the production release just in time for the next 3004.388.9 F/W, which is currently in Beta. I'm not in a rush, but at some point we have to bite the bullet, and let it rip!!! LOL!!!

I thought so as well; so I've just prepared the PR for merge:
#440

Apologies for the delay. My wife and I just arrived home, coming back from my brother's birthday celebration, and I feel tired, so I'm going to bed early tonight to get some much-needed sleep.

It needs your final review and approval, as well we need to draft a form post that properly describes the full release.

OK, sounds good. I think there's not a lot that needs to be explained or described since the main purpose of the 1.4.0 release is to add the WebGUI page that supports existing functionality already available in the SSH CLI menus.
The only part that would need some clarification is the "F/W Update Checks" Cron Schedule on the WebGUI page, which, by design, does not offer the full "custom schedule" functionality available on the CLI menu.

No worries we can do the release tomorrow buddy. Have a goodnight!

Sounds good. Have a good night!!

I'll think on the post for the forums on how I want to handle it, I think slamming everyone with a list of PRs may not be ideal 🤣

Yes, exactly. Something "short and sweet" should be good enough!!! 😉 Most people don't even read the release notes carefully anyway, LOL!!!

I feel the release notes are more for me at this point for when I need to go back through them hahaha! Goodnight bud! Chat tomorrow!

@Martinski4GitHub
Copy link
Collaborator Author

BTW, I think this 1.4.0 release is pretty much ready for prime time!! I don't know if you want to issue the production release just in time for the next 3004.388.9 F/W, which is currently in Beta. I'm not in a rush, but at some point we have to bite the bullet, and let it rip!!! LOL!!!

I thought so as well; so I've just prepared the PR for merge:
#440

Apologies for the delay. My wife and I just arrived home, coming back from my brother's birthday celebration, and I feel tired, so I'm going to bed early tonight to get some much-needed sleep.

It needs your final review and approval, as well we need to draft a form post that properly describes the full release.

OK, sounds good. I think there's not a lot that needs to be explained or described since the main purpose of the 1.4.0 release is to add the WebGUI page that supports existing functionality already available in the SSH CLI menus.
The only part that would need some clarification is the "F/W Update Checks" Cron Schedule on the WebGUI page, which, by design, does not offer the full "custom schedule" functionality available on the CLI menu.

No worries we can do the release tomorrow buddy. Have a goodnight!

Sounds good. Have a good night!!

I'll think on the post for the forums on how I want to handle it, I think slamming everyone with a list of PRs may not be ideal 🤣

Yes, exactly. Something "short and sweet" should be good enough!!! 😉 Most people don't even read the release notes carefully anyway, LOL!!!

I feel the release notes are more for me at this point for when I need to go back through them hahaha!

Ah, yes, I get it!! 👍

Goodnight bud! Chat tomorrow!

Sleep tight!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants