Dev 1.4.1 as Next Stable Release

[ExtremeFiretop]

Forms post update = COMPLETED
Readme update = COMPLETED
Version.txt update = COMPLETED
Dev 1.4.1 as Next Stable Release

What's Changed/Fixed?:

**PR: [ #[443] and #[444] - Attempted Bug Fixes for Fresh Installs
-Modified code to add missing Install Parameter for Script
-Attempted to move some logic around. Was eventually superseded by Martinski's PR's 445 below

PR: [ #445 ] - Code Improvements for Downloads
-Modified code to check and make sure the WebGUI ASP file is downloaded and installed.
-Modified code to check and make sure all configuration default settings are initialized.
(Thanks @Martinski4GitHub )

PR: [ #447 ] - Check for Version File
-Added a check for the version.txt file.
(Thanks @Martinski4GitHub )

PR: [ #448 ] - Fine-tuning Code
-Moving some Functions and Logic around
(Thanks @Martinski4GitHub )

PR: [ #449 ] - Patch Update Process
-Resolved some issues causing reports of having to run the update process twice, or reports of incorrectly identified updates.

As always, we highly recommend you update ASAP as this includes functional improvements and little bug fixes. Also as previously mentioned you must update to this version if you wish to have a smooth transition to the upcoming 1.4.0 release.

Thanks!

[ExtremeFiretop]

@Martinski4GitHub

Ready to ship on this PR.
Unless you want to wait for feedback from jksmurf

[Martinski4GitHub]

@Martinski4GitHub

Ready to ship on this PR. Unless you want to wait for feedback from jksmurf

I don't fully understand what he's trying to describe. It's vague and unclear, and without screenshots, I have no way to know for sure what he's actually seeing.

We could wait and see if they come back with feedback using the very latest code.

It's up to you. I know it's very late for you. Don't you have to go to the office today - this morning?

[ExtremeFiretop]

@Martinski4GitHub
Ready to ship on this PR. Unless you want to wait for feedback from jksmurf

I don't fully understand what he's trying to describe. It's vague and unclear, and without screenshots, I have no way to know for sure what he's actually seeing.

We could wait and see if they come back with feedback using the very latest code.

Yes he just came back with some valuable feedback and screenshots I believe.

It's up to you. I know it's very late for you. Don't you have to go to the office today - this morning?

Ha... Hahahahahahah.... With this snow? Probably will work from home if I don't call a sick day.
I also don't know if I told you but it's only one day a week on Tuesdays, so yes i should be going in today, but again people were kinda forecasting this snow storm putting us in a "stay in place - school /snow day" kinda mentality.

[Martinski4GitHub]

@Martinski4GitHub
Ready to ship on this PR. Unless you want to wait for feedback from jksmurf

I don't fully understand what he's trying to describe. It's vague and unclear, and without screenshots, I have no way to know for sure what he's actually seeing.
We could wait and see if they come back with feedback using the very latest code.

Yes he just came back with some valuable feedback and screenshots I believe.

The screenshots help, but I don't quite understand the steps he's describing, especially after step 5.
Perhaps, English is not his 1st language, and I understand that could make it difficult to communicate via the written word.

6. Ran up, it shows I am on 1.4.1; and 1.4.1 is the latest; BUT
7. If I say (n) it goes back to the menu and (incorrectly) shows there IS an update; AND
8. If I say (y) it updates, goes back to the menu and (still incorrectly) shows there IS an update.
9. BUT if I then run up AGAIN (y or n), there is no update? Did you do a sneaky 1.4.1 fix while I was doing this :-)?

I'm confused by the above steps.

6. Ran up... ???
What does that mean exactly in this context?

7. If I say (n)... ??? 8. If I say (y)... ???
I have no idea what he's referring to, and I don't have the time to read through every single post to figure out the way he "speaks" the language.

[ExtremeFiretop]

Ah! I can help!

[ExtremeFiretop]

@Martinski4GitHub
Ready to ship on this PR. Unless you want to wait for feedback from jksmurf

I don't fully understand what he's trying to describe. It's vague and unclear, and without screenshots, I have no way to know for sure what he's actually seeing.
We could wait and see if they come back with feedback using the very latest code.

Yes he just came back with some valuable feedback and screenshots I believe.

The screenshots help, but I don't quite understand the steps he's describing, especially after step 5. Perhaps, English is not his 1st language, and I understand that could make it difficult to communicate via the written word.

6. Ran up, it shows I am on 1.4.1; and 1.4.1 is the latest; BUT
7. If I say (n) it goes back to the menu and (incorrectly) shows there IS an update; AND
8. If I say (y) it updates, goes back to the menu and (still incorrectly) shows there IS an update.
9. BUT if I then run up AGAIN (y or n), there is no update? Did you do a sneaky 1.4.1 fix while I was doing this :-)?

I'm confused by the above steps.

So he ran the "up" from the main menu. for Update section utility. But if he selects no to force update, or yes, it returns showing there is an update
Like the below:

7. If I say (n)... ??? 8. If I say (y)... ??? I have no idea what he's referring to, and I don't have the time to read through every single post to figure out the way he "speaks" the language.

Then if he runs the update utility again with either selection (to force update or not)
he returns to no updates available, like below:

[ExtremeFiretop]

What I think is happening is the build time stamp got updated when preparing for this PR, which triggered the visuals of an update being available even though the version didn't change, which confused him. (Since hes technically on the dev branch when downloading via curl)

Selecting no, goes back to the main menu, and continues to show the visuals of an update being available but the version matching (confusing?)

Then, he goes back and actually updates with a force update, it comes back to still showing an update available, that bit I don't really understand, that's probably the bug.

Then when he opens it again, and backs out, even without updating, it correctly reflects theres no updates available.

[ExtremeFiretop]

Hopefully I put that in more English language for you ;)

[Martinski4GitHub]

@Martinski4GitHub
Ready to ship on this PR. Unless you want to wait for feedback from jksmurf

I don't fully understand what he's trying to describe. It's vague and unclear, and without screenshots, I have no way to know for sure what he's actually seeing.
We could wait and see if they come back with feedback using the very latest code.

Yes he just came back with some valuable feedback and screenshots I believe.

The screenshots help, but I don't quite understand the steps he's describing, especially after step 5. Perhaps, English is not his 1st language, and I understand that could make it difficult to communicate via the written word.

6. Ran up, it shows I am on 1.4.1; and 1.4.1 is the latest; BUT
7. If I say (n) it goes back to the menu and (incorrectly) shows there IS an update; AND
8. If I say (y) it updates, goes back to the menu and (still incorrectly) shows there IS an update.
9. BUT if I then run up AGAIN (y or n), there is no update? Did you do a sneaky 1.4.1 fix while I was doing this :-)?

I'm confused by the above steps.

So he ran the "up" from the main menu. for Update section utility. But if he selects no to force update, or yes, it returns showing there is an update Like the below:

7. If I say (n)... ??? 8. If I say (y)... ??? I have no idea what he's referring to, and I don't have the time to read through every single post to figure out the way he "speaks" the language.

Then if he runs the update utility again with either selection (to force update or not) he returns to no updates available, like below:

OK, now, that is absolutely very clear, and the screenshots reinforce what you're saying.
Compared to what he wrote in his post - it's like he's speaking in broken English.

Thank you for the translation & clarification!! LOL!!!

[ExtremeFiretop]

@Martinski4GitHub

Thats the thing about being dyslexic, I barely understand English as it is, every sentence is an effort to get right, so decoding broken English is my specialty. That's as a FACT ;)

Btw to re-confirm my "that's probably the bug" in my statement above, here is the visual of my attempt at force updating when an update was showing available, and returning to an update still showing as available:

[Martinski4GitHub]

What I think is happening is the build time stamp got updated when preparing for this PR, which triggered the visuals of an update being available even though the version didn't change, which confused him. (Since hes technically on the dev branch when downloading via curl)

Yeah, changing the timestamp right in the middle of testing would certainly create such a scenario.

Selecting no, goes back to the main menu, and continues to show the visuals of an update being available but the version matching (confusing?)

Well, the actual version string did not change - only the timestamp would have changed in the middle testing.

Then, he goes back and actually updates with a force update, it comes back to still showing an update available, that bit I don't really understand, that's probably the bug.

Then when he opens it again, and backs out, even without updating, it correctly reflects theres no updates available.

I'd say the only way to know for sure is to have the user re-test from the beginning without us changing anything at all while he's testing.

[ExtremeFiretop]

What I think is happening is the build time stamp got updated when preparing for this PR, which triggered the visuals of an update being available even though the version didn't change, which confused him. (Since hes technically on the dev branch when downloading via curl)

Yeah, changing the timestamp right in the middle of testing would certainly create such a scenario.

Selecting no, goes back to the main menu, and continues to show the visuals of an update being available but the version matching (confusing?)

Well, the actual version string did not change - only the timestamp would have changed in the middle testing.

Exactly; I only mention confusing in his eyes as a user, we know better that the visual is normal if the timestamp is updated. That I'm not so concerned on. It's the following bit of the report when he mentions he updated and returns to an update still available that is more concerning; and I was able to recreate that instance.

Then, he goes back and actually updates with a force update, it comes back to still showing an update available, that bit I don't really understand, that's probably the bug.
Then when he opens it again, and backs out, even without updating, it correctly reflects theres no updates available.

I'd say the only way to know for sure is to have the user re-test from the beginning without us changing anything at all while he's testing.

I will try myself now, but without updating the timestamp for fun it may be tricky to recreate.

[Martinski4GitHub]

@Martinski4GitHub

Thats the thing about being dyslexic, I barely understand English as it is, every sentence is an effort to get right, so decoding broken English is my specialty. That's as a FACT ;)

LOL!!! But, at least, I understand your messages a lot more, and I assume that English is not your native language.
Perhaps, I'm being a hard-ass. I'm so used to dealing with other engineers for over 3 decades, where we "speak the same language" and, since our job requires us to be clear & precise in our verbal & written communications, anything less sounds vague & imprecise, especially when it comes to technology, H/W and S/W reports, bug reports, etc.

Btw to re-confirm my "that's probably the bug" in my statement above, here is the visual of my attempt at force updating when an update was showing available, and returning to an update still showing as available:

Can you reproduce this consistently, every time?
I'm going to bed in about 10 minutes, so I'll be signing off shortly. I'll continue later today in the evening, if you have not found what the root cause is.

Have a good night, bud!!

[ExtremeFiretop]

LOL!!! But, at least, I understand your messages a lot more, and I assume that English is not your native language. Perhaps, I'm being a hard-ass. I'm so used to dealing with other engineers for over 3 decades, where we "speak the same language" and, since our job requires us to be clear & precise in our verbal & written communications, anything less sounds vague & imprecise, especially when it comes to technology, H/W and S/W reports, bud reports, etc.

French is the language I was born and raised with on the Quebec side, but considering Gatineau is so close to Ottawa i've always considered myself fully bilingual. How I have room for learning coding after french I have no idea.

Can you reproduce this consistently, every time? I'm going to bed in about 10 minutes, so I'll be signing off shortly. I'll continue later today in the evening, if you have not found what the root cause is.

Have a good night, bud!!

No I cannot reproduce anymore since the build time stamp did not get updated again. I'm sure if I update it again now (or find a way to fake an update) that I can recreate it though.

[ExtremeFiretop]

@Martinski4GitHub

By adding sleeps and manually editing the file I recreated the problem again:

Also I noticed that this screen doesn't seem right if we have visuals of an update available it should probably show the screen for an update available as well:

[Martinski4GitHub]

LOL!!! But, at least, I understand your messages a lot more, and I assume that English is not your native language. Perhaps, I'm being a hard-ass. I'm so used to dealing with other engineers for over 3 decades, where we "speak the same language" and, since our job requires us to be clear & precise in our verbal & written communications, anything less sounds vague & imprecise, especially when it comes to technology, H/W and S/W reports, bud reports, etc.

French is the language I was born and raised with on the Quebec side, but considering Gatineau is so close to Ottawa i've always considered myself fully bilingual. How I have room for learning coding after french I have no idea.

LOL!!!

Can you reproduce this consistently, every time? I'm going to bed in about 10 minutes, so I'll be signing off shortly. I'll continue later today in the evening, if you have not found what the root cause is.
Have a good night, bud!!

No I cannot reproduce anymore since the build time stamp did not get updated again. I'm sure if I update it again now (or find a way to fake an update) that I can recreate it though.

If the root cause is indeed a changing timestamp, then this would not be a problem with the actual production release since there would be no timestamp at all in the version file.

Good night. Signing off now...

[ExtremeFiretop]

LOL!!! But, at least, I understand your messages a lot more, and I assume that English is not your native language. Perhaps, I'm being a hard-ass. I'm so used to dealing with other engineers for over 3 decades, where we "speak the same language" and, since our job requires us to be clear & precise in our verbal & written communications, anything less sounds vague & imprecise, especially when it comes to technology, H/W and S/W reports, bud reports, etc.

French is the language I was born and raised with on the Quebec side, but considering Gatineau is so close to Ottawa i've always considered myself fully bilingual. How I have room for learning coding after french I have no idea.

LOL!!!

Can you reproduce this consistently, every time? I'm going to bed in about 10 minutes, so I'll be signing off shortly. I'll continue later today in the evening, if you have not found what the root cause is.
Have a good night, bud!!

No I cannot reproduce anymore since the build time stamp did not get updated again. I'm sure if I update it again now (or find a way to fake an update) that I can recreate it though.

If the root cause is indeed a changing timestamp, then this would not be a problem with the actual production release since there would be no timestamp at all in the version file.

Good night. Signing off now...

Goodnight buddy!