Dev 1.4.2 as Next Stable Release#456
Conversation
Minor Fixes
Minor Cosmetic Fixes and Additions
Some additional code improvements.
Code Improvements
Patch Changelog and Email Notifications
…otifications Patch Changelog and Email Notifications and Fix Uninstall
- Fixed bug introduced in PR #453 which was allowing installation in all unsupported models. - Miscellaneous code improvements.
Fix and Improvements
Improved uninstallation workflow when users attempt to install MerlinAU on unsupported router models. Now the code will automatically ask users to uninstall right after informing them that their current router model is unsupported. On such scenarios, this provides users a quick & easy way to uninstall.
Code Improvement
|
I think this is ready. Feel free to review :) |
|
Also; should we still remove the build number from the version.txt or have we stopped caring yet? |
Looks good to me!! |
I think we should remove it from both branches now, and then we'll add it to the development branch only when it's needed. My 2 cents. |
Done! And Post is ready :) |
Martinski4GitHub
left a comment
There was a problem hiding this comment.
Good to go and ready to be shipped!!!
|
I'm being summoned to dinner. Talk to you later or perhaps tomorrow. |
Enjoy dinner! |
Forms post update = COMPLETED
Readme update = COMPLETED
Version.txt update = COMPLETED
Dev 1.4.2 as Next Stable Release
What's Changed/Fixed?:
PR: [ #451 ] - Minor Fixes and Additions
-After the Router PWD is set, we now add a successfully tested or unvalidated result to the main menu.
-Change the wording for the update process to fix nitpicks related to "anyways" vs "anyway" as reported by: jksmurf
-Update Minimum Versions to 3 behind production
-Fix the WebUI status for the changelog approval being "Disabled" instead of "TBD"
-Fixes some visual nitpicks of the WebUI
PR: [ #452 ] - Code Improvements
-Make sure the "FW_New_Update_Changelog_Approval" option is initialized properly under all circumstances.
-Show the Password "Verified" status in GREEN = GOOD.
-Minor cleanup.
(Thanks @Martinski4GitHub )
PR: [ #453 ] - Fix Changelog and Email Notifications and Patch Uninstall
-Fix a report from nlurker here for blank changelog URLs in the email notifications: https://www.snbforums.com/threads/merlinau-v1-4-1-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951011
The Changelog check (pre-approval) was not running before the email notification with the run_now parameter.
-Quick fix to allow uninstall of the script when installed on unsupported routers as reported by mxxcon here: https://www.snbforums.com/threads/merlinau-v1-4-1-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951128
PR: [ #454 ] - Improvement
-Miscellaneous code improvements.
(Thanks @Martinski4GitHub )
PR: [ #455 ] - Fixes and Code Improvements
-Improved uninstallation workflow when users attempt to install MerlinAU on unsupported routers.
-Now the code will automatically prompt users to uninstall immediately after informing them that their current router model is unsupported. In such scenarios, this provides users a quick & easy way to uninstall.
(Thanks @Martinski4GitHub )
As always, we highly recommend you update ASAP as this includes functional improvements and little bug fixes.
Thanks!