Skip to content

Script Update Email Notifications#458

Merged
Martinski4GitHub merged 6 commits intodevfrom
ExtremeFiretop-NewNotifications
Apr 15, 2025
Merged

Script Update Email Notifications#458
Martinski4GitHub merged 6 commits intodevfrom
ExtremeFiretop-NewNotifications

Conversation

@ExtremeFiretop
Copy link
Owner

Script Update Email Notifications

Script Update Email Notifications
@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Apr 15, 2025

@Martinski4GitHub

As requested by maghuro here: https://www.snbforums.com/threads/merlinau-v1-4-2-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951576

I am implementing email notifications only when the script auto-updates and is non-interactive.

Screenshots:
image
image

@Martinski4GitHub
Copy link
Collaborator

@Martinski4GitHub

As requested by maghuro here: https://www.snbforums.com/threads/merlinau-v1-4-2-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951576

I am implementing email notifications only when the script auto-updates and is non-interactive.

Yeah, good call. It wouldn't really make sense to send notifications if the user is updating the script manually in an interactive session - the user knows he's doing the script update (we can only hope :>).

@ExtremeFiretop
Copy link
Owner Author

@Martinski4GitHub
As requested by maghuro here: https://www.snbforums.com/threads/merlinau-v1-4-2-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951576
I am implementing email notifications only when the script auto-updates and is non-interactive.

Yeah, good call. It wouldn't really make sense to send notifications if the user is updating the script manually in an interactive session - the user knows he's doing the script update (we can only hope :>).

I also didn't want to clash with AMTM update notifications. Which advise the user if they don't have auto updates enabled.

Then like you said we don't need to notify in an interactive session either.

So basically only via cron and with auto updates enabled do we send these would be the clean way to implement it I think

@Martinski4GitHub
Copy link
Collaborator

@Martinski4GitHub
As requested by maghuro here: https://www.snbforums.com/threads/merlinau-v1-4-2-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951576
I am implementing email notifications only when the script auto-updates and is non-interactive.

Yeah, good call. It wouldn't really make sense to send notifications if the user is updating the script manually in an interactive session - the user knows he's doing the script update (we can only hope :>).

I also didn't want to clash with AMTM update notifications. Which advise the user if they don't have auto updates enabled.

Yes, good point too. Users may complain of getting redundant emails. LOL!!!

Then like you said we don't need to notify in an interactive session either.

So basically only via cron and with auto updates enabled do we send these would be the clean way to implement it I think

Agreed.

@ExtremeFiretop
Copy link
Owner Author

@Martinski4GitHub
As requested by maghuro here: https://www.snbforums.com/threads/merlinau-v1-4-2-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951576
I am implementing email notifications only when the script auto-updates and is non-interactive.

Yeah, good call. It wouldn't really make sense to send notifications if the user is updating the script manually in an interactive session - the user knows he's doing the script update (we can only hope :>).

I also didn't want to clash with AMTM update notifications. Which advise the user if they don't have auto updates enabled.

Yes, good point too. Users may complain of getting redundant emails. LOL!!!

At first that was going to be my reply; "look this will cause redundant emails because AMTM already handles it."
But I noticed AMTM only handles it if an addon is "out of date" and our auto-update always keeps it "up to date" so makes sense why some users would want notifications for auto-updates being enabled.

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and good to go!!

@Martinski4GitHub Martinski4GitHub merged commit 9265e41 into dev Apr 15, 2025
1 check passed
@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-NewNotifications branch April 16, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants