Merged
Conversation
Reverse Sync Back into Dev
Issues Resolved: 1. Gray out Install Script checkbox if Auto updates is enabled. 2. Changed the wording if Auto updates are enabled. 4. ChangeLog in the WebUI cannot by browsed by direction keys
Changes: 1. Allow Changelog function to detect migration of code base from 3004 to 3006 firmware.
Resolved: 1. Only warn and do not hard blocking setting credential's even if Web Access Restrictions is enabled. Was originally discussed in this post: #292 (comment)
Adjust Script Version
Patch WebUI
Fix Web Access Restrictions Regex
Add Missing Changelog Patch
Missing Comment Updates
Actually Fix Web Access Restrictions
Currently does not flatten the content so word wraps are missed such as:
"any additionnal GN must be
manually reconfigured."
Also only checks between 2 matches firmware versions, which won't exist between firmware jumps in changelog 388.8 and 3006.
This commit addresses these both by flattening the new lines and also checking for the date format instead of the firmware versions.
Set Estimates to TBD when disabling
Previously changing the postpone period in the WebUi did not correctly recalculate the new estimate flash time. Now we force it too. As well previously the estimate did not reset to (TBD) when disabling update checks.
Making it an optional parameter instead
Minor Fixes to Fix the Invalid Password Focus on Edge/Chrome Currently on Edge/Chrome; even when the password is validated; the user is unable to click elsewhere like to change the postpone period. This fixes that issue.
Fix Memory Clearing for Low Memory Models
Adding Back conn_diag
Re-Implementing Memory Diff Solution from 0993ac5
Removing Memory Subtraction Solution Lowering overhead by half from 50% to 25%
Undoing Memory Based Changes
Fix Web-Access Restrictions, Changelog Verification, WebUI Selections, and Firmware Run Estimates
- - Fixed WebUI Access Restrictions to check for valid CIDR IP address blocks. - Fixed for changelog tag check going from NG to 3006. - Coding improvements and fine-tuning.
Fixes and Improvements
- Fixed bug where the wrong tooltip message is displayed when the password status is INVALID due to a failed login attempt. - Fixed missing tooltip messages for 2 statuses: "NOT Verified" and "Verified." - Improved on fix for the focus issue on WebGUI using MS Edge and Google Chrome browsers.
Fixes and Improvements
Made changes in the memory requirements for routers with 512MB RAM to be less restrictive and allow to proceed with the F/W flash.
Modified RAM Requirements for F/W Flash Process
Owner
Author
|
This is good to merge whenever your ready :) |
Martinski4GitHub
approved these changes
Jun 3, 2025
Collaborator
Martinski4GitHub
left a comment
There was a problem hiding this comment.
Approved & ready to go live!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forms post update = READY
Readme update = COMPLETED
Version.txt update = COMPLETED
Dev 1.4.7 Next Stable Release
What's Changed/Fixed?:
PR: [ #475 ] - Patch WebUI
PR: [ #476 ] - Fix Web-Access Restrictions, Changelog Verification, WebUI Selections, and Firmware Run Estimates
"any additionnal GN must be
manually reconfigured."
PR: [ #478 ] - Fixes and Improvements
PR: [ #479 ] - More Fixes and Improvements
PR: [ #480 ] -Modified RAM Requirements for F/W Flash Process
a) Lower the initial required RAM overhead from 50% to 35% before the ZIP file is downloaded, and then lower it again to 25% after the F/W image is extracted.
b) When trying to acquire more available RAM, the code attempts to disable some ASUS/TrendMicro services:
AsusNat Tunnel, AiProtection, Traffic Analyzer/Monitor, and Bandwidth Monitor
As always, we highly recommend you update ASAP as this includes functional improvements and little bug fixes.
Thanks!