Closed
Conversation
For AiMesh nodes, the password is always the same as the primary with no options to change, so we don't need the passwordloginchecker helper for those. And for an AP, they can be set to any password that doesn't match the primary, so displaying invalid password for those seems incorrect.
Double Whoops. I was right the first time
Removing All AiMesh functionality
Owner
Author
|
Considering the discussion around this feature point to it still having value, and we have alternative methods to workaround the AP issue. I will close this PR and branch for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR is solution 1. (Make it less annoying)
This solution 2. (Remove it completely)