-
Notifications
You must be signed in to change notification settings - Fork 1
fix errors in export event program and tracker program #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tracker/events
and tracker/trackedEntities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested against v38 and v41 and working (it downloads tracker programs with data)
@gqcorneby Sorry for the confusion, I removed the re-review because I saw no changes pushed since my previous review ("orgUnits is always truthy") and I thought you were in the processing of checking it. Let me know when that snippet is ready to be checked, all the other code looked good to me. |
@tokland Thank you for the clarification! For some reason, I did not receive a notification for the comment (also I can't see it). But I will check this. |
src/data/Dhis2RelationshipTypes.ts
Outdated
//can't use both orgUnitMode and ouMode in v41 | ||
return { | ||
ouMode, | ||
...(isOuReq && orgUnits && { orgUnit: buildOrgUnitsParameter(orgUnits) }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
being an array (Ref[]) , orgUnits
is always truthy, so the 2nd condition does nothing. Review if we need to check the length or what's the condition.
I re-posted the review, I think that was it, sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we will only change the error message (it should not get to there anyway), but otherwise, all code looks good to me, approving.
📌 References
📝 Implementation
/tracker/events
and/tracker/trackedEntities
to use a fallback (instances || (events/trackedEntities) || []/tracker/events
payload to not includeprogramStage
when it is null🔥 Notes for the reviewer
📹 Screenshots/Screen capture
📑 Others