Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error msgs #72

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Improve error msgs #72

merged 2 commits into from
Nov 20, 2024

Conversation

9sneha-n
Copy link
Contributor

📌 References

📝 Implementation

  1. Parse TEA names in save error message
  2. Parse Current user in save error message
  3. Parse error message in fetch

📹 Screenshots/Screen capture

Uploading Screenshot 2024-11-19 at 1.56.20 PM.png…

🔥 Notes to the tester

@ifoche
Copy link
Member

ifoche commented Nov 19, 2024

Task linked: CU-86956tnhn Display errors in a bit more verbose way when possible

MiquelAdell
MiquelAdell approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@MiquelAdell MiquelAdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I see you even added the latest kind of error I requested, the non unique error.
Screenshot 2024-11-19 at 10 31 43

@MiquelAdell
Copy link
Contributor

Oh, and if you could also resolve the conflicts. I've been merging to develop today, thanks!

@9sneha-n
Copy link
Contributor Author

Oh, and if you could also resolve the conflicts. I've been merging to develop today, thanks!

done.

anagperal
anagperal approved these changes Nov 20, 2024
View reviewed changes
Copy link

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n ! Could be interesting to have something similar for other projects?

@MiquelAdell MiquelAdell merged commit 1119f14 into development Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelAdell MiquelAdell MiquelAdell approved these changes

@anagperal anagperal anagperal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@9sneha-n @ifoche @MiquelAdell @anagperal