Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: treatment link initial #82

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Jan 19, 2025

📌 References

📝 Implementation

  1. Display Treatment and Indication Link fields as drop-down
  2. Add a save button to treatment and indication sections
  3. On save, populate the link dropdowns
  4. Save selected treatment/indication links

📹 Screenshots/Screen capture

treatment-indication-link-1.mov
treatment-indication-link-2.mov

🔥 Notes to the tester

@9sneha-n 9sneha-n changed the base branch from master to development January 19, 2025 18:52
@9sneha-n 9sneha-n changed the base branch from development to feat/v41-upgrade February 4, 2025 07:27
@ifoche
Copy link
Member

ifoche commented Feb 5, 2025

@9sneha-n 9sneha-n marked this pull request as ready for review February 5, 2025 06:02
Base automatically changed from feat/v41-upgrade to development February 6, 2025 07:12
Copy link

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n ! Only two comments about repeated code that if it's not necessary like that better unify in one (code-only review)

@9sneha-n
Copy link
Contributor Author

9sneha-n commented Feb 7, 2025

thanks @9sneha-n ! Only two comments about repeated code that if it's not necessary like that better unify in one (code-only review)

Thanks @anagperal , its fixed now.

@9sneha-n 9sneha-n requested a review from anagperal February 7, 2025 08:26
Copy link

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n !! 🎉

Copy link
Contributor

@MiquelAdell MiquelAdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working

@MiquelAdell MiquelAdell merged commit a889e50 into development Feb 7, 2025
1 check passed
@MiquelAdell MiquelAdell deleted the feature/pps-indication-treatment branch February 7, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants