Small refactor for some repositories calling other repositories #212
Conversation
| const trainingModuleRepository = new TrainingModuleDefaultRepository(configRepository, instanceRepository); | ||
| const landingPageRepository = new LandingPageDefaultRepository(configRepository, instanceRepository); | ||
| const documentRepository = new Dhis2DocumentRepository(instance); | ||
| export function getCompositionRoot(api: D2Api) { |
There was a problem hiding this comment.
What was the idea for the baseUrl -> api transition? Typically we'd like to pass the less specific object (baseUrl) and let the composition root how to build D2Api.
There was a problem hiding this comment.
Actually, I did it because it was the way we were doing it in the skeleton now, but as you mentioned it, it makes sense to give the baseUrl as the param and let the compositionRoot build the D2Api
There was a problem hiding this comment.
I see. Yes, we follow this approach in the skeleton, but mainly for historical reasons—index.tsx originally handled building the old d2 object. However, that's not ideal. A D2Api is a 'data' concern, whereas baseUrl is a 'webapp' concern. So, let's pass the least compromising option instead.
📌 References
📝 Implementation
Some repositories are called by other repositories, which is a code smell. For those were we were just for the intention to get the api, I pass the api instead of the repository.