Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix new golangci-lint issues #376

Merged
merged 1 commit into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/mp4ff-pslister/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ func printPS(name string, nr int, ps []byte, psInfo interface{}, verbose bool) {
if verbose && psInfo != nil {
jsonPS, err := json.MarshalIndent(psInfo, "", " ")
if err != nil {
log.Fatalf(err.Error())
log.Fatalln(err.Error())
}
fmt.Printf("%s\n", string(jsonPS))
}
Expand Down
2 changes: 1 addition & 1 deletion mp4/file_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func TestDecodeFileWithNoLazyMdatOption(t *testing.T) {
if frag.Mdat.lazyDataSize != 0 {
t.Error("decLazyDataSize is expected to be 0")
}
if frag.Mdat.Data == nil || len(frag.Mdat.Data) == 0 {
if len(frag.Mdat.Data) == 0 {
t.Error("Mdat Data is expected to be non-nil")
}
}
Expand Down
2 changes: 1 addition & 1 deletion mp4/helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func assertNoError(t *testing.T, err error) {
func assertError(t *testing.T, err error, msg string) {
t.Helper()
if err == nil {
t.Errorf(msg)
t.Error(msg)
}
}

Expand Down
2 changes: 1 addition & 1 deletion mp4/pssh_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func TestPsshFromBase64(t *testing.T) {
d := deep.Equal(buf.String(), expected)
if len(d) > 0 {
for _, l := range d {
t.Errorf(l)
t.Error(l)
}
}
}
Expand Down
Loading