fix: addressing feedback in upstream PR 10

Eyevinn · Sep 6, 2024 · 6c7f7a0 · 6c7f7a0
1 parent b19172f
commit 6c7f7a0
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 10 deletions.
diff --git a/src/api/ateliereLive/pipelines/multiviews/multiviews.ts b/src/api/ateliereLive/pipelines/multiviews/multiviews.ts
@@ -38,9 +38,6 @@ export async function createMultiviewForPipeline(
   productionSettings: ProductionSettings,
   sourceRefs: SourceReference[]
 ): Promise<ResourcesPipelineMultiviewResponse[]> {
-  // TODO Check if this can be cleaned out. This is an old code and dont know the purpose of it, therefor I dont want to remove it yet.
-  // const multiviewPresets = await getMultiviewPresets();
-
   const pipeline = productionSettings.pipelines.find((p) =>
     p.multiviews ? p.multiviews?.length > 0 : undefined
   );

diff --git a/src/api/ateliereLive/pipelines/streams/streams.ts b/src/api/ateliereLive/pipelines/streams/streams.ts
@@ -252,8 +252,6 @@ export async function createStream(
             streams: sourceToPipelineStreams
           }
         };
-        // TODO Check if this can be cleaned out. This is an old code and dont know the purpose of it, therefor I dont want to remove it yet.
-        // return sourceToPipelineStreams;
       }
       const updatedViewsForSource = viewsForSource.map((v) => {
         return { ...v, label: source.name };

diff --git a/src/api/manager/job/syncInventory.ts b/src/api/manager/job/syncInventory.ts
@@ -7,8 +7,7 @@ import { WithId } from 'mongodb';
 
 type SourceWithoutLastConnected = Omit<Source, 'lastConnected'>;
 
-// TODO: getSourcesFromAPI should return ResourcesSourceResponse and changed to our model later
-async function getSourcesFromAPI() {
+async function getSourcesFromAPI(): Promise<SourceWithoutLastConnected[]> {
   const ingests = await getIngests();
   const resolvedIngests = (
     await Promise.allSettled(ingests.map((ingest) => getIngest(ingest.uuid)))

diff --git a/src/components/inventory/Inventory.tsx b/src/components/inventory/Inventory.tsx
@@ -41,9 +41,7 @@ export default function Inventory() {
   function getSourcesToDisplay(
     filteredSources: Map<string, SourceWithId>
   ): React.ReactNode {
-    return Array.from(
-      filteredSources.size >= 0 ? filteredSources.values() : sources.values()
-    ).map((source, index) => {
+    return Array.from(filteredSources.values()).map((source, index) => {
       if (source.status !== 'purge') {
         return (
           <SourceListItem