Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug fixes on filter #11

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: bug fixes on filter #11

merged 2 commits into from
Sep 6, 2024

Conversation

Saelmala
Copy link

@Saelmala Saelmala commented Sep 6, 2024

Solves filter errors:

  1. The previous logic did not handle the case where there were no items matching the filter criteria. Which was the case for SRT sources.
  2. Adds new type of ingest_type to filter on: Test pattern (where ingest source.type === MediaSourceGenerator).
  3. Now, if no filters are on, no sources are shown. By default NDI, SDI, and SRT filters are on and the Test Pattern filter is off.

@Saelmala Saelmala self-assigned this Sep 6, 2024
LucasMaupin
LucasMaupin approved these changes Sep 6, 2024
View reviewed changes
Copy link

@LucasMaupin LucasMaupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmen237
Copy link

LGTM

@Saelmala Saelmala merged commit 37c5d8e into main Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasMaupin LucasMaupin LucasMaupin approved these changes

@malmen237 malmen237 malmen237 approved these changes

Assignees

@Saelmala Saelmala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saelmala @malmen237 @LucasMaupin