Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addressing feedback in upstream PR 10 #12

Merged
merged 1 commit into from
Sep 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/api/ateliereLive/pipelines/multiviews/multiviews.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ export async function createMultiviewForPipeline(
productionSettings: ProductionSettings,
sourceRefs: SourceReference[]
): Promise<ResourcesPipelineMultiviewResponse[]> {
// TODO Check if this can be cleaned out. This is an old code and dont know the purpose of it, therefor I dont want to remove it yet.
// const multiviewPresets = await getMultiviewPresets();

const pipeline = productionSettings.pipelines.find((p) =>
p.multiviews ? p.multiviews?.length > 0 : undefined
);
Expand Down
2 changes: 0 additions & 2 deletions src/api/ateliereLive/pipelines/streams/streams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,6 @@ export async function createStream(
streams: sourceToPipelineStreams
}
};
// TODO Check if this can be cleaned out. This is an old code and dont know the purpose of it, therefor I dont want to remove it yet.
// return sourceToPipelineStreams;
}
const updatedViewsForSource = viewsForSource.map((v) => {
return { ...v, label: source.name };
Expand Down
3 changes: 1 addition & 2 deletions src/api/manager/job/syncInventory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import { WithId } from 'mongodb';

type SourceWithoutLastConnected = Omit<Source, 'lastConnected'>;

// TODO: getSourcesFromAPI should return ResourcesSourceResponse and changed to our model later
async function getSourcesFromAPI() {
async function getSourcesFromAPI(): Promise<SourceWithoutLastConnected[]> {
const ingests = await getIngests();
const resolvedIngests = (
await Promise.allSettled(ingests.map((ingest) => getIngest(ingest.uuid)))
Expand Down
4 changes: 1 addition & 3 deletions src/components/inventory/Inventory.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ export default function Inventory() {
function getSourcesToDisplay(
filteredSources: Map<string, SourceWithId>
): React.ReactNode {
return Array.from(
filteredSources.size >= 0 ? filteredSources.values() : sources.values()
).map((source, index) => {
return Array.from(filteredSources.values()).map((source, index) => {
if (source.status !== 'purge') {
return (
<SourceListItem
Expand Down
Loading