Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves the problem with starting productions with websocket-sources #15

Merged
merged 43 commits into from
Sep 23, 2024

Conversation

malmen237
Copy link

No description provided.

@malmen237 malmen237 marked this pull request as ready for review September 11, 2024 18:16
@Saelmala
Copy link

Disabled if no production configuration is set:

When production configuration is set (e.g. LD + HQ Pipeline):

Production with HTML and Media Player sources:

Multiviewer example, with example HTML URL loaded and Media player placeholder:

src/components/sourceCard/SourceCard.tsx Outdated Show resolved Hide resolved
src/components/sourceCard/SourceThumbnail.tsx Outdated Show resolved Hide resolved
src/components/sourceCards/SourceCards.tsx Outdated Show resolved Hide resolved
src/components/sourceCards/SourceCards.tsx Outdated Show resolved Hide resolved
src/components/startProduction/StartProductionButton.tsx Outdated Show resolved Hide resolved
src/hooks/pipelines.ts Outdated Show resolved Hide resolved
Copy link

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linda made the initial changes, I added bug fixes. I'm marking this as approved after Linda has given her approval.

};

export function SourceThumbnail({ source, src }: SourceThumbnailProps) {
export function SourceThumbnail({ source, src, type }: SourceThumbnailProps) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file still used?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, good catch. Will remove.

@Saelmala Saelmala changed the base branch from feat-media-html-inputs to main September 23, 2024 09:28
@Saelmala Saelmala merged commit 042b407 into main Sep 23, 2024
4 checks passed
@Saelmala Saelmala deleted the fix/start-prod-w-websocket branch September 23, 2024 09:52
birme pushed a commit that referenced this pull request Sep 23, 2024
…6414c39c

chore(deps): bump semver and nodemon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants