Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added possibility to add, change and remove multiviewers on running production #37

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

malmen237
Copy link

@malmen237 malmen237 commented Oct 14, 2024

What does this do?

This PR makes it possible to add, update and remove multiviewers when a production is running.

Also containing minor fixes:

  • Buttons for multiview-config and start production are disabled when no pipelines have been selected.
  • Commented out code with TODOs has been removed

View when preparing production:
Screenshot 2024-10-14 at 09 45 11

View when running production:
Screenshot 2024-10-14 at 09 45 29

The configuration looks the same when on a running production and not, but when saving the config you get a warning to confirm that you are about to updated a running config:
Screenshot 2024-10-14 at 12 56 48

@malmen237 malmen237 marked this pull request as ready for review October 15, 2024 07:38
src/components/modal/Modal.tsx Outdated Show resolved Hide resolved
@malmen237 malmen237 force-pushed the feat/add-mv-layout-on-running-prod branch from 48d5dc8 to 3cd8ad0 Compare October 16, 2024 05:18
@malmen237 malmen237 force-pushed the feat/add-mv-layout-on-running-prod branch from 3cd8ad0 to 0c0831c Compare October 16, 2024 05:28
@malmen237 malmen237 merged commit 838e449 into main Oct 16, 2024
4 checks passed
@malmen237 malmen237 deleted the feat/add-mv-layout-on-running-prod branch October 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants